Merge lp:~openerp-dev/openerp-web/6.1-opw-586024-ado into lp:openerp-web/6.1

Proposed by Amit Dodiya (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/6.1-opw-586024-ado
Merge into: lp:openerp-web/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/js/view_list.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/6.1-opw-586024-ado
Reviewer Review Type Date Requested Status
Xavier ALT Pending
Naresh(OpenERP) Pending
Review via email: mp+147325@code.launchpad.net

Description of the change

Hello,

"[BACKPORT] web-client gives object error while opening the list view of system parameter if we write comma in product name"

Steps:
1). Login as admin and install stock module
2). Make sure you're using the extended interface
3). Create a new product with the name "test 1,2"
Now goto "Settings -> Configuration -> Parameters -> Configuration Parameters", you will get object error.

Code is back-ported from 7.0

Regards,
Amit Dodiya

To post a comment you must log in.

Unmerged revisions

2502. By Amit Dodiya (OpenERP)

[BACKPORT] web-client gives object error while opening the list view of system parameter if we write comma in product name

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list.js'
2--- addons/web/static/src/js/view_list.js 2012-06-25 07:20:46 +0000
3+++ addons/web/static/src/js/view_list.js 2013-02-08 08:57:26 +0000
4@@ -907,7 +907,7 @@
5 // set) a human-readable version. m2o does not have this issue
6 // because the non-human-readable is just a number, where the
7 // human-readable version is a pair
8- if (value && (ref_match = /([\w\.]+),(\d+)/.exec(value))) {
9+ if (value && (ref_match = /^([\w\.]+),(\d+)$/.exec(value))) {
10 // reference values are in the shape "$model,$id" (as a
11 // string), we need to split and name_get this pair in order
12 // to get a correctly displayable value in the field