Merge lp:~openerp-dev/openerp-web/6.1-opw-581438-cpa into lp:openerp-web/6.1

Proposed by Chirag Patel (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/6.1-opw-581438-cpa
Merge into: lp:openerp-web/6.1
Diff against target: 20 lines (+7/-3)
1 file modified
addons/web/static/src/js/formats.js (+7/-3)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/6.1-opw-581438-cpa
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+132882@code.launchpad.net

Description of the change

Hello,

Float_time widget show wrong format of time.

Demo: Human Resources > Time Tracking > Timesheets
1) Create new record.
2) sign-in and sign out directly.
3) Enter 8 quntity in Timesheet Lines record and save.

It try to convert this float value 7.9988888888888887

Observed: "Difference" field value "07:60".
Expected: "Difference" field value "08:00".

Thanks.

To post a comment you must log in.

Unmerged revisions

2478. By Chirag Patel (OpenERP)

[FIX] Fixed float_time widget show wrong format of time.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/formats.js'
2--- addons/web/static/src/js/formats.js 2012-07-03 14:02:51 +0000
3+++ addons/web/static/src/js/formats.js 2012-11-05 12:49:22 +0000
4@@ -128,9 +128,13 @@
5 value = Math.abs(value);
6 pattern = '-' + pattern;
7 }
8- return _.str.sprintf(pattern,
9- Math.floor(value),
10- Math.round((value % 1) * 60));
11+ var hour = Math.floor(value);
12+ var min = Math.round((value % 1) * 60);
13+ if (min == 60){
14+ min = 0;
15+ hour = hour + 1;
16+ }
17+ return _.str.sprintf(pattern, hour, min);
18 case 'many2one':
19 // name_get value format
20 return value[1];