Merge lp:~openerp-dev/openerp-web/6.1-opw-579322-cpa into lp:openerp-web/6.1

Proposed by Chirag Patel (OpenERP)
Status: Merged
Approved by: Xavier ALT
Approved revision: 2459
Merged at revision: 2471
Proposed branch: lp:~openerp-dev/openerp-web/6.1-opw-579322-cpa
Merge into: lp:openerp-web/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/js/view_form.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/6.1-opw-579322-cpa
Reviewer Review Type Date Requested Status
Jiten (OpenERP) (community) Approve
OpenERP Core Team Pending
Review via email: mp+124918@code.launchpad.net

Description of the change

Hello,

Demo:
1) Edit user preferences.
2) In language combo box select the empty line.
   > Field becomes red.
3) Return to English.

Observed: Field stay with "Red" color.
Expected: Field color should be "Alpine Blue".

Thanks.

To post a comment you must log in.
Revision history for this message
Jiten (OpenERP) (jiten-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2012-09-03 13:17:44 +0000
3+++ addons/web/static/src/js/view_form.js 2012-09-18 13:19:23 +0000
4@@ -1467,7 +1467,7 @@
5 if (!this.disable_utility_classes) {
6 this.$element.toggleClass('disabled', this.readonly);
7 this.$element.toggleClass('required', this.required);
8- if (show_invalid) {
9+ if (show_invalid || this.$element.hasClass('invalid')) {
10 this.$element.toggleClass('invalid', !this.is_valid());
11 }
12 }