Merge lp:~openerp-dev/openerp-web/6.1-opw-577241-bth into lp:openerp-web/6.1

Proposed by Bhumi Thakkar (Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/6.1-opw-577241-bth
Merge into: lp:openerp-web/6.1
Diff against target: 29 lines (+6/-2)
2 files modified
addons/web/static/src/js/view_list.js (+1/-0)
addons/web/static/src/js/views.js (+5/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/6.1-opw-577241-bth
Reviewer Review Type Date Requested Status
Jiten (OpenERP) (community) Disapprove
OpenERP Core Team Pending
Review via email: mp+116802@code.launchpad.net

Description of the change

Hello,

     In My Timesheet, On Refresh go error.

1. Human Resource => Time Tracking => My Timesheet.
2. Refresh or press F5

Observed: 'Error is coming TypeError: fvg.arch is undefined'
Expected: 'On refresh page should be reload again without error.'

My Timesheet is server action.In server action to perform action action id is not passed in action so action is extended for id and in listview this.fields_view = {} is not initialized in init method so error is coming 'Error: QWeb2 - template['ViewManagerDebug']: Runtime Error: TypeError: dict.view.fields_view is undefined' after initialized it is resolved.

Thanks.

To post a comment you must log in.
Revision history for this message
Jiten (OpenERP) (jiten-openerp) wrote :

Hello,

I have tested as your description but i am not able to reproduce this error.

And no need to merge this proposal for further.

So, i am rejecting this branch.

But, thanks for your contribution.

review: Disapprove

Unmerged revisions

2416. By Bhumi Thakkar (Open ERP)

[FIX] in Server action,action is extended by id.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_list.js'
2--- addons/web/static/src/js/view_list.js 2012-06-25 07:20:46 +0000
3+++ addons/web/static/src/js/view_list.js 2012-07-26 06:51:26 +0000
4@@ -57,6 +57,7 @@
5 this.previous_colspan = null;
6 this.colors = null;
7
8+ this.fields_view = {};
9 this.columns = [];
10
11 this.records = new Collection();
12
13=== modified file 'addons/web/static/src/js/views.js'
14--- addons/web/static/src/js/views.js 2012-06-29 10:53:25 +0000
15+++ addons/web/static/src/js/views.js 2012-07-26 06:51:26 +0000
16@@ -173,8 +173,11 @@
17 this.rpc('/web/action/run', {
18 action_id: action.id,
19 context: action.context || {}
20- }).then(function (action) {
21- self.do_action(action, on_closed)
22+ }).then(function (act) {
23+ act = _.extend({
24+ id : action.id
25+ }, act || {});
26+ self.do_action(act, on_closed)
27 });
28 },
29 ir_actions_client: function (action) {