Merge lp:~openerp-dev/openerp-web/6.1-opw-576121-bth into lp:openerp-web/6.1

[Bhumi Thakkar (Open ERP)]

Hello,

    web client makes multiple reads when clicking a button to perform action.Order of requests is not proper.

1. Sales => Sales => Sales Orders
2. Open any record and click on any button for example compute.

Observed: 'Main record is going to be saved of current model ('sale.order') then related models ('sale.order.line') records are going to be saved and then action is going to perform.'
Expected: 'First Action should perform then records of current model and related model should save.'

Order of request is changed on execute action. First call function of action perform and the recursive_save function and reload.

Thanks.

[lp:~openerp-dev/openerp-web/6.1-opw-576121-bth]

2378. By Bhumi Thakkar (Open ERP) on 2012-06-28

[FIX] Reload on button action.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

> First Action should perform then records of current model and related model should save.

That does not make sense, it means if user changed information in form or line when executing action action is always going to see old data, then data is going to be reloaded, and new data is going to be lost.

review: Needs Information

Unmerged revisions

2378. By Bhumi Thakkar (Open ERP) on 2012-06-28

[FIX] Reload on button action.

2377. By Bhumi Thakkar (Open ERP) on 2012-06-28

[FIX] Order of request is changed on action of button.

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2012-06-25 07:20:46 +0000
+++ addons/web/static/src/js/view_form.js	2012-06-28 13:01:41 +0000
@@ -1298,25 +1298,26 @@
                 });
                 return def.promise();
             } else {
-                return self.on_confirmed();
+                return self.on_confirmed().then( function() {
+                    self.view.recursive_save().pipe( function() { self.view.reload(); });
+                });
             }
         };
         if (!this.node.attrs.special) {
             this.view.force_dirty = true;
-            return this.view.recursive_save().pipe(exec_action);
-        } else {
-            return exec_action();
+            if (!this.view.datarecord.id) {
+                return this.view.recursive_save().pipe(exec_action);
+            }
         }
+        return exec_action();
     },
     on_confirmed: function() {
         var self = this;
-
         var context = this.node.attrs.context;
         if (context && context.__ref) {
             context = new openerp.web.CompoundContext(context);
             context.set_eval_context(this._build_eval_context());
         }
-
         return this.view.do_execute_action(
             _.extend({}, this.node.attrs, {context: context}),
             this.view.dataset, this.view.datarecord.id, function () {