Merge lp:~openerp-dev/openerp-web/6.1-opw-575297-msh into lp:openerp-web/6.1

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of date or datetime widget icon shown on top right of header when the date or datetime field is in readonly mode that is when oe_input_icon_disabled class is toggled.

Demo :- Open any form view in which date field is in readonly mode, so you will get the date picker icon on the right top of the header.

Thanks.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

That fix does not seem correct, now the readonly date & datetime widget does not look like a date or datetime widget anymore if it's a readonly.

Also, seems to work for me when testing on runbot, as-is, with what browser do you encounter issue?

e.g. if I go on Runbot, 6.1 branch, "Connect", go to `Sales > Sales > Sales Orders` in debug view, open a sale order in form view, edit view to add 'readonly="1"` on "date_order", save, then reload form.

I see icon at the right place in readonly field.

review: Needs Fixing

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello,

I have checked the issue with firefox and getting the caledar picker icon at top right corner as there is a css to set it to top right when is readonly, in chrome you will get the calendar icon at input itself.

As the field is readonly so why we should show the calendar picker icon.

I have added a screenshot at,

https://picasaweb.google.com/113982374997358022324/July182012

To generate it open any sale order which is in done state, so the datetime field will have readonly and you will get that calendar icon at top right corner in mozilla and at the field itself in chrome.

Thanks.

review: Needs Resubmitting

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Field still doesn't look like datetime anymore when disabled

review: Disapprove

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello Xavier,

Thanks for the review, but did you check the screenshot I uploaded at https://picasaweb.google.com/113982374997358022324/July182012.

Would you please re-check the screenshot, because I am not talking about datetime widget itself but the icon of datetime is shown on top left corner that is near to Logout link when form has readonly datetime field.

Thanks.

review: Needs Resubmitting

Unmerged revisions

2378. By Mohammed Shekha(Open ERP) on 2012-06-29

[FIX]Fixed the issue of date icon shown on header when the date or datetime field is in readonly mode, when oe_input_icon_disabled is toggled the date icon will shown on top right of header.

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2012-06-25 06:58:12 +0000
+++ addons/web/static/src/css/base.css	2012-06-29 06:35:23 +0000
@@ -1525,12 +1525,7 @@
     width: 100%;
 }
 .openerp .oe_input_icon_disabled {
-    position: absolute;
-    cursor: default;
-    opacity: 0.5;
-    filter:alpha(opacity=50);
-    right: 5px;
-    top: 3px;
+    display: none;
 }
 .openerp .oe_trad_field.touched {
     border: 1px solid green !important;