Merge lp:~openerp-dev-web/openobject-client-web/o2m_improved into lp:~openerp-dev/openobject-client-web/trunk-dev-web

[Vaibhav Darji]

Improve o2m for unsaved parent when creating new child.

[lp:~openerp-dev-web/openobject-client-web/o2m_improved]

3055. By Vaibhav Darji on 2010-04-27

Remove unnecessary import.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Code is simple and pretty clean, which is nice, but from a UI standpoint there are still issues, I believe this needs deeper modifications as to how o2m is handled:

* (minor) the label on the "new o2m" button is still "save parent record" when parent is saved
* bigger issue, when an o2m is created the parent is automatically saved even though user never tried to save anything, and so if user changes mind (and goes do something else) record has still been created. Likewise, means one can not create o2m record if parent form is incomplete. Ideally, parent should be saved as late as possible (as in GTK client), meaning when *saving* the o2m record, not when adding new line I think

What do you think?

review: Needs Fixing

[Navrang Oza (noz-tiny)]

I agree whatever you said, but here problem is we are calling submit method to SAVE the current form (which includes everything - parent, o2m, m2m...).

- To make it like GTK, we have to change whole architecture for o2m.
- We have to save all o2m entries somewhere while creating new records more than one without affecting parent.
- To save the o2m records somewhere means we again have to call submit method or something? and without Parent ID what will be the reference for o2m records ?

you can understand what I mean to say.

Actually Amit sir sent a mail for this problem to FP sir when he created backlog first time for this task.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

> - To save the o2m records somewhere means we again have to call submit method or something? and without Parent ID what will be the reference for o2m records ?

yeah basically I was thinking of having the o2m record's save check if parent id exists, and if not ask for parent to save and then save itself. But if you think it's going to be too much work, we can just go with vda's current solution (which works) and add UI/UX improvements to the backlog.

[lp:~openerp-dev-web/openobject-client-web/o2m_improved]

3056. By Vaibhav Darji on 2010-04-29

[FIX] Fixed title.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

review: Approve

=== modified file 'addons/openerp/widgets/form/_o2m.py'
--- addons/openerp/widgets/form/_o2m.py	2010-04-14 10:11:55 +0000
+++ addons/openerp/widgets/form/_o2m.py	2010-04-29 10:04:28 +0000
@@ -48,7 +48,7 @@
     """One2Many widget
     """
     template = "templates/one2many.mako"
-    params = ['id', 'parent_id', 'new_attrs', 'pager_info', 'switch_to', 'default_get_ctx']
+    params = ['id', 'parent_id', 'new_attrs', 'pager_info', 'switch_to', 'default_get_ctx', 'source']
     member_widgets = ['screen']
 
     form = None
@@ -66,7 +66,7 @@
 
         # get top params dictionary
         params = cherrypy.request.terp_params
-
+        self.source = params.source
         pprefix = ''
         if '/' in self.name:
             pprefix = self.name[:self.name.rindex('/')]

=== modified file 'addons/openerp/widgets/form/templates/one2many.mako'
--- addons/openerp/widgets/form/templates/one2many.mako	2010-03-26 10:20:08 +0000
+++ addons/openerp/widgets/form/templates/one2many.mako	2010-04-29 10:04:28 +0000
@@ -6,13 +6,15 @@
                     <td width="100%"><strong>${screen.string}</strong></td>
                     <td>
                         % if screen.editable and not readonly:
-                        <button type="button" id="${name}_btn_" title="${new_attrs['help']}" onclick="new One2Many('${name}', ${(screen.view_type == 'tree' or 0) and len(screen.widget.editors)}).create()" style="padding: 2px">
-                            % if parent_id:
+                        <button type="button" id="${name}_btn_" title="${_('Create new record.')}" onclick="new One2Many('${name}', ${(screen.view_type == 'tree' or 0) and len(screen.widget.editors)}).create()" style="padding: 2px">
                             <img src="/openerp/static/images/stock/gtk-new.png" width="16" height="16"/>
-                            % endif
-                            % if not parent_id:
-                            <img src="/openerp/static/images/stock/gtk-save.png" width="16" height="16"/>
-                            % endif
+                            % if name == source:
+                            	<script type="text/javascript">
+                            		jQuery('#${name}_btn_').find('img').load(function() {
+                            			jQuery(this).click();
+                            		});
+                            	</script>
+                           	% endif
                         </button>
                         % endif
                         % if pager_info: