Merge lp:~openerp-dev-web/openobject-client-web/jquery-form-m2m into lp:~openerp-dev/openobject-client-web/trunk-dev-web

Proposed by Xavier (Open ERP)
Status: Superseded
Proposed branch: lp:~openerp-dev-web/openobject-client-web/jquery-form-m2m
Merge into: lp:~openerp-dev/openobject-client-web/trunk-dev-web
Diff against target: 81 lines (+20/-24)
1 file modified
addons/openerp/widgets/templates/listgrid.mako (+20/-24)
To merge this branch: bzr merge lp:~openerp-dev-web/openobject-client-web/jquery-form-m2m
Reviewer Review Type Date Requested Status
OpenERP R&D Web Team Pending
Review via email: mp+24124@code.launchpad.net

This proposal has been superseded by a proposal from 2010-04-27.

Description of the change

A few tentative improvements to jquery usages

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/widgets/templates/listgrid.mako'
2--- addons/openerp/widgets/templates/listgrid.mako 2010-04-22 10:02:06 +0000
3+++ addons/openerp/widgets/templates/listgrid.mako 2010-04-26 13:29:18 +0000
4@@ -201,9 +201,8 @@
5 % if data and 'sequence' in map(lambda x: x[0], itertools.chain(headers,hiddens)):
6 <script type="text/javascript">
7 // flag is used to check sorting is active or not //
8-
9- flag = "${'_terp_sort_key' in cherrypy.request.params.keys()}"
10-
11+ var flag = "${'_terp_sort_key' in cherrypy.request.params.keys()}";
12+
13 if(flag == 'False') {
14 var drag = getElementsByTagAndClassName('tr','grid-row');
15 for(var grid=0; grid < drag.length; grid++)
16@@ -212,7 +211,6 @@
17 new Droppable(drag[grid], {accept: [drag[grid].className], ondrop: new ListView('${name}').dragRow, hoverclass: 'grid-rowdrop'});
18 }
19 }
20-
21 </script>
22 % endif
23
24@@ -220,7 +218,7 @@
25 //Make all records Editable by Double-click
26 var view_type = jQuery('[id*=_terp_view_type]').val();
27 var editable = jQuery('[id*=_terp_editable]').val();
28- jQuery('table[id=${name}_grid] tr.grid-row').each(function(index, row) {
29+ jQuery('table#${name}_grid tr.grid-row').each(function(index, row) {
30 jQuery(row).dblclick(function(event) {
31 if (!(event.target.className == 'checkbox grid-record-selector' || event.target.className == 'listImage')) {
32 if (view_type == 'tree') {
33@@ -235,7 +233,7 @@
34 });
35 });
36
37- jQuery('table[id=${name}_grid] tr.grid-row').each(function(index, row) {
38+ jQuery('table#${name}_grid tr.grid-row').each(function(index, row) {
39 jQuery(row).click(function(event) {
40 if (!(event.target.className == 'grid-cell selector' || event.target.className == 'checkbox grid-record-selector' || event.target.className == 'listImage')) {
41 if (view_type == 'tree') {
42@@ -244,24 +242,22 @@
43 }
44 });
45 });
46-
47- if(view_type == 'form') {
48- if(jQuery('[id=${name}_set]').length > 0) {
49- var ids = jQuery('input[id=${name}/_terp_ids]').val();
50-
51- if(ids != '[]') {
52- jQuery('table[id=${name}_grid] tr.grid-row').each(function(index, row) {
53- var links = jQuery(jQuery(row).find('td')[1]).find('span');
54- if(links.length > 0) {
55- var link_text = jQuery(links[1]).html();
56- var record_id = jQuery(row).attr('record');
57- jQuery(links[1]).html("<a href='javascript: void(0)' onclick=do_select("+ record_id + "," + "'" + '${name}' +"'"+")>"+link_text+"</a>")
58- }
59- });
60- }
61- }
62- }
63- </script>
64+
65+ if (view_type == 'form') {
66+ if (jQuery('#${name}_set').length) {
67+ if (jQuery('input#${name}/_terp_ids').val() != '[]') {
68+ jQuery('table#${name}_grid tr.grid-row td:nth-child(2) span span').each(function(index, span) {
69+ var link_text = jQuery(span).text();
70+ var record_id = jQuery(span).parents('tr.grid-row').attr('record');
71+ jQuery(span).empty().append(
72+ jQuery('<a>').attr('href', '#').click(function () {
73+ do_select(record_id, '${name}');
74+ return false;
75+ }).text(link_text));});
76+ }
77+ }
78+ }
79+ </script>
80 </td>
81 </tr>
82

Subscribers

People subscribed via source and target branches