Merge lp:~openerp-community/web-addons/7.0-web_export_view_CSV into lp:~webaddons-core-editors/web-addons/7.0

[Lorenzo Battistini]

[REF] Exporting as CSV instead of XLS.
See https://bugs.launchpad.net/web-addons/+bug/1046342/comments/2

[Nhomar - Vauxoo (nhomar)]

Lorenzo.

Why not have both controllers?

I merged already excel ones, and i think if we have both it is better (I hate excel, but everybody love it :-()

review: Needs Information

[Eric Caudal - www.elico-corp.com (elicoidal)]

I had an issue starting the addons. Shouldnot it be in controllers.py:
import openerp.addons.web.http as openerpweb

from openerp.addons.web.controllers.main import ExcelExport

Eric CAUDAL

Eric Caudal
On 01/09/2013 13:57, Nhomar - Vauxoo wrote:

> Review: Needs Information
>
> Lorenzo.
>
> Why not have both controllers?
>
> I merged already excel ones, and i think if we have both it is better (I hate excel, but everybody love it :-()

[Nhomar - Vauxoo (nhomar)]

Eric,

I think this branch is marked as WIP it is not ready yet I think.

[Eric Caudal - www.elico-corp.com (elicoidal)]

OK: I tested it and so far so good anyway
Eric CAUDAL

Eric CaudalOn 01/09/2013 15:36, Nhomar - Vauxoo wrote:

> Eric,
>
> I think this branch is marked as WIP it is not ready yet I think.

[Lorenzo Battistini (elbati)]

On 09/01/2013 07:57 AM, Nhomar - Vauxoo wrote:
> Lorenzo.
>
> Why not have both controllers?

This would be good.
But we can't work on it now.
I'm changing the branch owner so that everybody can improve it.

Unmerged revisions

10. By Lorenzo Battistini on 2013-08-05

[REF] Exporting as CSV instead of XLS.
See https://bugs.launchpad.net/web-addons/+bug/1046342/comments/2

=== modified file 'web_export_view/controllers.py'
--- web_export_view/controllers.py	2013-08-05 14:42:26 +0000
+++ web_export_view/controllers.py	2013-08-05 14:42:26 +0000
@@ -25,11 +25,11 @@
 
 import web.http as openerpweb
 
-from web.controllers.main import ExcelExport
-
-
-class ExcelExportView(ExcelExport):
-    _cp_path = '/web/export/xls_view'
+from web.controllers.main import CSVExport
+
+
+class CSVExportView(CSVExport):
+    _cp_path = '/web/export/csv_view'
 
     @openerpweb.httprequest
     def index(self, req, data, token):

=== modified file 'web_export_view/static/js/web_advanced_export.js'
--- web_export_view/static/js/web_advanced_export.js	2013-08-05 14:42:26 +0000
+++ web_export_view/static/js/web_advanced_export.js	2013-08-05 14:42:26 +0000
@@ -29,10 +29,10 @@
             var self = this;
             this._super.apply(this, arguments);
             self.$el.find('.oe_sidebar').append(QWeb.render('AddExportViewMain', {widget: self}));
-            self.$el.find('.oe_sidebar_export_view_xls').on('click', self.on_sidebar_export_view_xls);
+            self.$el.find('.oe_sidebar_export_view_csv').on('click', self.on_sidebar_export_view_csv);
         },
 
-        on_sidebar_export_view_xls: function() {
+        on_sidebar_export_view_csv: function() {
             // Select the first list of the current (form) view
             // or assume the main view is a list view and use that
             var self = this,
@@ -80,7 +80,7 @@
             });
             $.blockUI();
             view.session.get_file({
-                url: '/web/export/xls_view',
+                url: '/web/export/csv_view',
                 data: {data: JSON.stringify({
                     model : view.model,
                     headers : export_columns_names,

=== modified file 'web_export_view/static/xml/web_advanced_export.xml'
--- web_export_view/static/xml/web_advanced_export.xml	2013-08-05 14:42:26 +0000
+++ web_export_view/static/xml/web_advanced_export.xml	2013-08-05 14:42:26 +0000
@@ -6,7 +6,7 @@
     <div class="oe_form_dropdown_section">
         <button class="oe_dropdown_toggle oe_dropdown_arrow">Export Current View</button>
         <ul class="oe_dropdown_menu">
-            <li class="oe_sidebar_export_view_xls"><span>Excel</span></li>
+            <li class="oe_sidebar_export_view_csv"><span>CSV</span></li>
         </ul>
     </div>
 </t>