Merge lp:~openerp-community/openobject-server/trunk-gantt-view-add-progress into lp:openobject-server

Proposed by Simone Orsi
Status: Rejected
Rejected by: Raphael Collet (OpenERP)
Proposed branch: lp:~openerp-community/openobject-server/trunk-gantt-view-add-progress
Merge into: lp:openobject-server
Diff against target: 11 lines (+1/-0)
1 file modified
openerp/addons/base/rng/view.rng (+1/-0)
To merge this branch: bzr merge lp:~openerp-community/openobject-server/trunk-gantt-view-add-progress
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Disapprove
Review via email: mp+89648@code.launchpad.net

Description of the change

Gantt view does not handle 'progress' attribute and progress value was hardcoded as "100" into web_gantt module (see https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress)

To post a comment you must log in.
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

We have discussed internally the issue of supporting progress in Gantt views. It was decided that version 6.1 will not support it, because of some visual issues (defining progress on tasks gives a progress on project level that does not match the progress of projects). Moreover, Gantt views in the web client have just been reimplemented a few days ago.

Hence I reject this merge proposal, for the sake of not leaving it pending.

Thanks anyway for your contribution!

Raphael

review: Disapprove

Unmerged revisions

3977. By Simone Orsi

added 'progress' gantt view allowed attributes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/rng/view.rng'
2--- openerp/addons/base/rng/view.rng 2012-01-16 14:01:58 +0000
3+++ openerp/addons/base/rng/view.rng 2012-01-23 10:17:28 +0000
4@@ -358,6 +358,7 @@
5 <rng:optional><rng:attribute name="date_string"/></rng:optional>
6 <rng:optional><rng:attribute name="string"/></rng:optional>
7 <rng:optional><rng:attribute name="default_group_by"/></rng:optional>
8+ <rng:optional><rng:attribute name="progress"/></rng:optional>
9 <rng:zeroOrMore>
10 <rng:optional><rng:ref name="level"/></rng:optional>
11 <rng:optional><rng:ref name="field"/></rng:optional>