Code review comment for lp:~openerp-community/openobject-addons/trunk-bug-923440-base_contact_finalise6.1

Dear Amit,

Thanks for the clear words. However, I tried to make the changes
compatible therefore, it would be a good to be integrated into 6.1 as it
makes the base_contact module usable in 6.1.

The transfer to 6.2 and 7 has to be considered when the new approach is
ready. I have some doubt that the people that require the base_contact
module are fully satisfied with the first approach as it is now. But I
guess its too early to get it from the code. Is there a link that
describes the concept?

Best Regards

Etienne

On 30.04.2012 07:01, Amit Parik (OpenERP) wrote:
> Review: Disapprove
>
> Hello Etienne,
>
> base_contact is already removed from the trunk.
> You have provided a this improvement for 6.1. As per our stable version's policy we doesn't accept the big improvement.
>
> This is a big improvement for 6.1, Sorry to say this but we have consider only blocking point as well as small bug fixes for the 6.1 branch . So we can not consider this type of big improvement for 6.1
>
> Thanks for the contribution!
>