Merge lp:~openerp-community/openobject-addons/contact-id-solution-for-v7-contact-management into lp:openobject-addons/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-community/openobject-addons/contact-id-solution-for-v7-contact-management |
Merge into: | lp:openobject-addons/7.0 |
Diff against target: |
398 lines (+43/-37) 21 files modified
account/account_invoice.py (+1/-1) account/account_invoice_view.xml (+1/-1) account/edi/invoice_action_data.xml (+1/-1) account/report/account_invoice_report.py (+4/-3) account/report/account_print_invoice.rml (+3/-4) analytic/analytic.py (+1/-1) crm/crm_lead.py (+4/-4) crm/wizard/crm_opportunity_to_phonecall.py (+4/-3) crm_claim/crm_claim.py (+1/-1) portal_sale/portal_sale_data.xml (+2/-2) project/project.py (+1/-1) purchase/edi/purchase_order_action_data.xml (+1/-1) purchase/purchase.py (+3/-1) purchase/report/request_quotation.rml (+1/-1) sale/edi/sale_order_action_data.xml (+1/-1) sale/report/sale_order.rml (+2/-2) sale/sale.py (+3/-2) sale_crm/wizard/crm_make_sale.py (+2/-2) sale_stock/sale_stock.py (+2/-1) stock/report/picking.rml (+3/-3) stock/stock.py (+2/-1) |
To merge this branch: | bzr merge lp:~openerp-community/openobject-addons/contact-id-solution-for-v7-contact-management |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Dony (Odoo) | Disapprove | ||
Review via email: mp+159320@code.launchpad.net |
Unmerged revisions
- 9037. By Raphaël Valyi - http://www.akretion.com
-
[FIX] contact mixin for account.
analytic. account, project.project and crm.claim. I consider all objects who should get a contact mixin have it now - 9036. By Raphaël Valyi - http://www.akretion.com
-
[FIX] green on CRM: meeting and phone calls for contacts. Yeahbzr diff crm we can finally call ourselves a true ERP... beware SAP the end is near...
- 9035. By Sébastien BEAU - http://www.akretion.com
-
[FIX] opening the invoice from the res.partner is now possible
- 9034. By Raphaël Valyi - http://www.akretion.com
-
[FIX] contact_id solution: contact_id is optional, fall back on partner_id
- 9033. By njeudy
-
[FIX] this should fix picking reports for contact_id
- 9032. By Sébastien BEAU - http://www.akretion.com
-
[REF] remove contact_id as mixin already add it
- 9031. By Sébastien BEAU - http://www.akretion.com
-
[IMP] improve reporting on invoice, now we can also group by and filter by contact
- 9030. By njeudy
-
[FIX] more account invoice report polish for contact_id
- 9029. By Raphaël Valyi - http://www.akretion.com
-
[FIX] green on all email, #SorrySAP ;)
- 9028. By Sébastien BEAU - http://www.akretion.com
-
[FIX] fix invoice and picking creation. Wrong the contact should be the contact selected on the sale order, and the partner the commercial_entity related to this contact
Please see my comment on the server merge proposal this branch depends on: /code.launchpad .net/~openerp- community/ openobject- server/ contact- id-solution- for-v7- contact- management/ +merge/ 159316
https:/
In addition:
- l.178,207: the fact that you need to specifically follow ".commercial_ entity_ id" illustrates the problem of the mixin not dealing properly with multiple partner fields in the original model (as mentioned in the server MP review)
- l.236: shouldn't that be 'contact_id' rather than 'contact'?