Merge lp:~openerp-community/openerp-web/stefan-therp_lp883445 into lp:openerp-web
Proposed by
Stefan Rijnhart (Opener)
Status: | Merged |
---|---|
Merge reported by: | Fabien Meghazi (OpenERP) |
Merged at revision: | not available |
Proposed branch: | lp:~openerp-community/openerp-web/stefan-therp_lp883445 |
Merge into: | lp:openerp-web |
Diff against target: |
45 lines (+16/-1) 2 files modified
addons/web/static/src/js/view_form.js (+5/-1) addons/web/static/src/xml/base.xml (+11/-0) |
To merge this branch: | bzr merge lp:~openerp-community/openerp-web/stefan-therp_lp883445 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Xavier (Open ERP) (community) | Approve | ||
Stefan Rijnhart (Opener) (community) | Needs Resubmitting | ||
Fabien Meghazi (OpenERP) | Pending | ||
Review via email: mp+80737@code.launchpad.net |
Description of the change
This branch honours the 'string' attribute of a form view's 'group' tag. The presence of a non-empty string attribute triggers the rendering of the group in a bordered frame, labelled with the contents of the string attribute. This way, the behaviour of the new web client is equal to that of the GTK client and the old web client.
To post a comment you must log in.
In keeping with the naming conventions for the form view, I think the widget should be called `WidgetGroup` rather than `WidgetGroupFrame` (and of course fieldset's default style is not exactly sexy but that's a different issue, not one for this functional improvement).
Apart from that, looks OK to me, though I'll let fme look over it (as he's the go-to guy for form views).