Merge lp:~openerp-community/openerp-product-attributes/import-from-addons-extra-trunk into lp:~product-core-editors/openerp-product-attributes/6.1

Status: Merged
Merged at revision: 2
Proposed branch: lp:~openerp-community/openerp-product-attributes/import-from-addons-extra-trunk
Merge into: lp:~product-core-editors/openerp-product-attributes/6.1
Diff against target: 0 lines
To merge this branch: bzr merge lp:~openerp-community/openerp-product-attributes/import-from-addons-extra-trunk
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Numérigraphe (community) Abstain
Alexandre Fayolle - camptocamp Needs Information
Review via email: mp+135473@code.launchpad.net

Description of the change

[ADD] Import product_* modules from lp:openobject-addons/extra-trunk

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

The module product_gs1_128 has been proposed for inclusion in the stock and logistic barcode project (https://code.launchpad.net/~numerigraphe/stock-logistic-barcode/6.1-gs1-128-barcodes/+merge/134657)

We really don't want the same module to live in 2 different projects and to diverge. Can you synchronize with Lionel Sausin as to where that module belongs ?

Thanks.

review: Needs Information
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Hi,
This module is actually not related to products at all. It only provides and API for other modules to be able do decompose the data of gs1 barcodes.
So I suggest not to include it here.
Thanks,
Lionel.

review: Needs Fixing (remove product_gs1_128)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hello,

We have to merge this branch as soon as possible because the modules here are no longer present in the extra-addons branch.

I am going to remove the product_gs1_128 module from the branch because it is now clear that it will be in lp:stock-logistic-barcode thanks to Numérigraphe. By the way, the merge proposal for this module is still waiting [0].

Then, if nobody disagrees, I'll merge as is.

[0] https://code.launchpad.net/~numerigraphe/stock-logistic-barcode/6.1-gs1-128-barcodes/+merge/134657

Revision history for this message
Numérigraphe (numerigraphe) :
review: Approve
Revision history for this message
Numérigraphe (numerigraphe) :
review: Abstain
20. By Guewen Baconnier @ Camptocamp <email address hidden>

[DEL] product_gs1_128 will be in lp:stock-logistic-barcode

21. By Guewen Baconnier @ Camptocamp <email address hidden>

[MRG] from main

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

So, nobody disagree, I merge this branch without the product_gs1_128 module.

review: Approve
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

I think you mixed up the content in the README file. It mentions Stock And Logistic Barcode management.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Oups! good catch! Thanks

Preview Diff

Empty

Subscribers

People subscribed via source and target branches