Merge lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-5.0 into lp:openobject-client/5.0

Proposed by Nicolas DS
Status: Rejected
Rejected by: Naresh(OpenERP)
Proposed branch: lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-5.0
Merge into: lp:openobject-client/5.0
Diff against target: 33 lines (+9/-1)
1 file modified
bin/widget/view/form_gtk/ (+9/-1)
To merge this branch: bzr merge lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-5.0
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Disapprove
Review via email:
To post a comment you must log in.
Revision history for this message
Nicolas DS (zyphos) wrote :

Double click on a many2many widget open a new tab with the clicked resource in a form. Like Web client does.

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Nicolas DS,

Thank you for your Input.

I had reviewed and made a bit modification like instead of opening in a new tab allow the user to open a specific record (with a dialog as like as the one2many field) for modification.

and has been merge in trunk client with revision info as 1172 <email address hidden>


review: Approve
Revision history for this message
Nicolas DS (zyphos) wrote :


I was hesitating of opening it in new window, but the tab pros is that you have a tree view too.

So in your merge I see that you set the domain, but it is not needed if you open it in new window, because only one record (resource) is shown.

Another thing,
the merge proposal for the "trunk" version is here:

this is the merge proposal for the stable 5.0 version. Could you review merge in 5.0 too ?

thank you for the merge.

Nicolas DS

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Nicolas DS ,

Ok I have changed the domain instead of Ids the domain should be from the default domain passed either from xml or .py.

and regarding stable merge we cannot merge this right now in stable branch as this is new improvement and will be included in the next stable version.


Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

It will be include in next release for stable version. We included it in Trunk verison.


review: Disapprove

Unmerged revisions

1049. By Nicolas DS

[FIX] Many2many widget action open a new tab with the selected resource like Web Client does

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/widget/view/form_gtk/'
2--- bin/widget/view/form_gtk/ 2009-07-23 11:37:09 +0000
3+++ bin/widget/view/form_gtk/ 2010-02-23 14:13:15 +0000
4@@ -34,6 +34,7 @@
5 import interface
7 import rpc
8+import service
10 from modules.gui.window.win_search import win_search
12@@ -73,7 +74,8 @@
13 scroll.set_shadow_type(gtk.SHADOW_NONE)
15 self.screen = Screen(attrs['relation'], view_type=['tree'],
16- views_preload=attrs.get('views', {}))
17+ views_preload=attrs.get('views', {}),
18+ row_activate=self.row_activate)
19 scroll.add_with_viewport(self.screen.widget)
20 self.widget.pack_start(scroll, expand=True, fill=True)
22@@ -162,6 +164,12 @@
23 def set_value(self, model, model_field):
24 model_field.set_client(model, [ for x in self.screen.models.models])
26+ def row_activate(self, screen):
27+ """ Open new tab with the resource in it """
28+ gui_window = service.LocalService('gui.window')
29+ domain = [('id','in', screen.ids_get())]
30+ gui_window.create(None,, screen.id_get(), domain, u'form',
31+ screen.window, screen.context, u'form,tree')
33 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: