Merge lp:~openerp-commiter/openobject-addons/trunk-bug-943173-pna into lp:openobject-addons

Proposed by Pinakin Nayi (OpenERP)
Status: Rejected
Rejected by: Fabien (Open ERP)
Proposed branch: lp:~openerp-commiter/openobject-addons/trunk-bug-943173-pna
Merge into: lp:openobject-addons
Diff against target: 72 lines (+7/-7)
4 files modified
auth_openid/controllers/main.py (+1/-1)
auth_openid/static/src/css/openid.css (+2/-2)
auth_openid/static/src/js/auth_openid.js (+1/-1)
auth_openid/static/src/xml/auth_openid.xml (+3/-3)
To merge this branch: bzr merge lp:~openerp-commiter/openobject-addons/trunk-bug-943173-pna
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+109112@code.launchpad.net

Description of the change

Hello ,

The openobject-addon bug/943173 is Fix

Thanks,
pna

To post a comment you must log in.
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

already fixed in trunk

Unmerged revisions

6874. By Pinakin Nayi (OpenERP)

[FIX] auth_openid:auth_openid(need to backport from 6.1)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'auth_openid/controllers/main.py'
2--- auth_openid/controllers/main.py 2012-02-13 15:27:55 +0000
3+++ auth_openid/controllers/main.py 2012-06-07 11:43:22 +0000
4@@ -199,7 +199,7 @@
5 # TODO fill empty fields with the ones from sreg/ax
6 cr.commit()
7
8- u = req.session.login(dbname, login, key)
9+ u = req.session.authenticate(dbname, login, key, {} )
10
11 if not user_id:
12 session['message'] = 'This OpenID identifier is not associated to any active users'
13
14=== modified file 'auth_openid/static/src/css/openid.css'
15--- auth_openid/static/src/css/openid.css 2012-02-13 15:27:55 +0000
16+++ auth_openid/static/src/css/openid.css 2012-06-07 11:43:22 +0000
17@@ -1,9 +1,9 @@
18-.login .pane {
19+.oe_login .oe_login_pane {
20 width: 260px;
21 height: 175px;
22 }
23
24-.login .pane input[name='openid_url'] {
25+.oe_login .oe_login_pane input[name='openid_url'] {
26 background: #fff url(../img/login-bg.gif) no-repeat 1px;
27 padding-left: 20px;
28 }
29
30=== modified file 'auth_openid/static/src/js/auth_openid.js'
31--- auth_openid/static/src/js/auth_openid.js 2012-02-13 15:27:55 +0000
32+++ auth_openid/static/src/js/auth_openid.js 2012-06-07 11:43:22 +0000
33@@ -8,7 +8,7 @@
34 this._super.apply(this, arguments);
35 var self = this;
36
37- this._default_error_message = this.$element.find('.login_error_message').text();
38+ this._default_error_message = this.$element.find('.oe_login_error_message').text();
39
40 this.$openid_selected_button = $();
41 this.$openid_selected_input = $();
42
43=== modified file 'auth_openid/static/src/xml/auth_openid.xml'
44--- auth_openid/static/src/xml/auth_openid.xml 2012-02-13 15:27:55 +0000
45+++ auth_openid/static/src/xml/auth_openid.xml 2012-06-07 11:43:22 +0000
46@@ -3,7 +3,7 @@
47 <templates id="template" xml:space="preserve">
48
49 <t t-extend="Login">
50- <t t-jquery=".login .pane div#logo" t-operation="after">
51+ <t t-jquery=".oe_login .oe_login_pane .oe_login_logo" t-operation="after">
52 <ul class="openid_providers">
53 <li><a href="#login,password" title="Password" data-url="" id="btn_password">Password</a></li>
54 <li><a href="#google" title="Google" data-url="https://www.google.com/accounts/o8/id">Google</a></li>
55@@ -31,7 +31,7 @@
56 </t>
57 </t>
58 <t t-extend="Login">
59- <t t-jquery=".login .pane form ul li:nth-child(4)" t-operation="after">
60+ <t t-jquery=".oe_login .oe_login_pane form ul li:nth-child(4)" t-operation="after">
61 <li>
62 Google Apps Domain
63 </li>
64@@ -54,7 +54,7 @@
65 </t>
66
67 <t t-extend="Login">
68- <t t-jquery=".login .pane form ul li:has(input)">
69+ <t t-jquery=".oe_login .oe_login_pane form ul li:has(input)">
70 this.each(function() {
71 var $i = $(this),
72 dp = $i.find('input').attr('name');

Subscribers

People subscribed via source and target branches

to all changes: