Merge lp:~openerp-commiter/openobject-addons/trunk-bug-925375-fka into lp:openobject-addons

Proposed by Foram Katharotiya (OpenERP)
Status: Rejected
Rejected by: Fabien (Open ERP)
Proposed branch: lp:~openerp-commiter/openobject-addons/trunk-bug-925375-fka
Merge into: lp:openobject-addons
Diff against target: 15 lines (+3/-2)
1 file modified
crm/crm_lead_menu.xml (+3/-2)
To merge this branch: bzr merge lp:~openerp-commiter/openobject-addons/trunk-bug-925375-fka
Reviewer Review Type Date Requested Status
Amit Parik (community) Approve
OpenERP Core Team Pending
Review via email: mp+121149@code.launchpad.net

This proposal supersedes a proposal from 2012-06-22.

Description of the change

hello sir,

As per your suggestion Add groups in lead, oppertunities & contracts menu

Thanks,
FKA

To post a comment you must log in.
Revision history for this message
Amit Parik (amit-parik) wrote : Posted in a previous version of this proposal

Hello Foram,

This not seems to good. We have to assign only "base.group_sale_salesman" group.
For other group we have already improved the functionality of "implied_ids", So for other group this menu will automatically assigned.

And please merge with latest addons too.

Thank you!

Revision history for this message
Amit Parik (amit-parik) : Posted in a previous version of this proposal
review: Needs Fixing
6920. By Foram Katharotiya (OpenERP)

[IMP] remove groups in contracts menu

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello,

Now It's ok.

Thank you!

review: Approve
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

no need anymore. If you have access to the root sales menu, you are a salesman.

Unmerged revisions

6920. By Foram Katharotiya (OpenERP)

[IMP] remove groups in contracts menu

6919. By Foram Katharotiya (OpenERP)

[IMP] Add groups in lead,oppertunity & contracts menu

6918. By Foram Katharotiya (OpenERP)

[MERGE] merge with parent branch

6917. By Foram Katharotiya (OpenERP)

[FIX]in crm_lead Add groups in menu

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'crm/crm_lead_menu.xml'
2--- crm/crm_lead_menu.xml 2012-08-04 18:46:05 +0000
3+++ crm/crm_lead_menu.xml 2012-08-24 10:22:20 +0000
4@@ -82,8 +82,9 @@
5 </record>
6
7 <menuitem name="Sales" id="base.menu_sales" parent="base.menu_base_partner" sequence="1" />
8- <menuitem name="Leads" id="menu_crm_leads" parent="base.menu_sales" action="crm_case_category_act_leads_all" sequence="2" />
9- <menuitem name="Opportunities" id="menu_crm_opportunities" parent="base.menu_sales" action="crm_case_category_act_oppor11" sequence="3" />
10+ <menuitem name="Leads" id="menu_crm_leads" parent="base.menu_sales" action="crm_case_category_act_leads_all" sequence="2" groups="base.group_sale_salesman"/>
11+ <menuitem name="Opportunities" id="menu_crm_opportunities" parent="base.menu_sales" action="crm_case_category_act_oppor11" sequence="3" groups="base.group_sale_salesman"/>
12+
13
14 </data>
15 </openerp>

Subscribers

People subscribed via source and target branches

to all changes: