Merge lp:~openerp-commiter/openobject-addons/6.0-bug-735368-tta into lp:openobject-addons/6.0

Proposed by SnippetBucket.com
Status: Merged
Merged at revision: 4541
Proposed branch: lp:~openerp-commiter/openobject-addons/6.0-bug-735368-tta
Merge into: lp:openobject-addons/6.0
Diff against target: 13 lines (+0/-3)
1 file modified
hr_expense/hr_expense.py (+0/-3)
To merge this branch: bzr merge lp:~openerp-commiter/openobject-addons/6.0-bug-735368-tta
Reviewer Review Type Date Requested Status
Jay Vora (Serpent Consulting Services) (community) Approve
Review via email: mp+58633@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Tejas,

Thanks for the fix.

However, please be careful that when you remove any code, its parental references/imports if not needed, should be removed as well.

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_expense/hr_expense.py'
2--- hr_expense/hr_expense.py 2011-01-17 18:02:22 +0000
3+++ hr_expense/hr_expense.py 2011-04-21 07:02:21 +0000
4@@ -193,9 +193,6 @@
5 account_journal.write(cr, uid, [journal.id],{'analytic_journal_id':analytic_journal_ids[0]})
6 inv_id = invoice_obj.create(cr, uid, inv, {'type': 'in_invoice'})
7 invoice_obj.button_compute(cr, uid, [inv_id], {'type': 'in_invoice'}, set_total=True)
8- wf_service = netsvc.LocalService("workflow")
9- wf_service.trg_validate(uid, 'account.invoice', inv_id, 'invoice_open', cr)
10-
11 self.write(cr, uid, [exp.id], {'invoice_id': inv_id, 'state': 'invoiced'})
12 res = inv_id
13 return res