Merge lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa into lp:openerp-web
Proposed by
Paramjit Singh Sahota(OpenERP)
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Nicolas Vanhoren (OpenERP) | ||||
Proposed branch: | lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa | ||||
Merge into: | lp:openerp-web | ||||
Diff against target: |
12 lines (+2/-0) 1 file modified
addons/web/static/src/js/view_form.js (+2/-0) |
||||
To merge this branch: | bzr merge lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicolas Vanhoren (OpenERP) (community) | Disapprove | ||
Review via email: mp+106621@code.launchpad.net |
Description of the change
Hello,
It is fixed. I have modify code to Add and remove class on notebook/page to hide/show and active page on selection change.
Thanks,
PSA (Paramjit Singh).
To post a comment you must log in.
Unmerged revisions
- 2457. By Paramjit Singh Sahota(OpenERP)
-
[FIX][Trunk/6.1] view update on selection change.
This is really not a correct way to do it. You apply css styles on visible/invisible elements, completely ignoring the fact those styles will be added to *all* elements, not just the notebook pages. A correct way to do it is to customize or re-implement invisibility handling for the precise case of the notebook.