Merge lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa into lp:openerp-web

Proposed by Paramjit Singh Sahota(OpenERP)
Status: Rejected
Rejected by: Nicolas Vanhoren (OpenERP)
Proposed branch: lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa
Merge into: lp:openerp-web
Diff against target: 12 lines (+2/-0)
1 file modified
addons/web/static/src/js/view_form.js (+2/-0)
To merge this branch: bzr merge lp:~openerp-commiter/openerp-web/trunk-bug-992571-psa
Reviewer Review Type Date Requested Status
Nicolas Vanhoren (OpenERP) (community) Disapprove
Review via email: mp+106621@code.launchpad.net

Description of the change

Hello,

  It is fixed. I have modify code to Add and remove class on notebook/page to hide/show and active page on selection change.

Thanks,
PSA (Paramjit Singh).

To post a comment you must log in.
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

This is really not a correct way to do it. You apply css styles on visible/invisible elements, completely ignoring the fact those styles will be added to *all* elements, not just the notebook pages. A correct way to do it is to customize or re-implement invisibility handling for the precise case of the notebook.

review: Disapprove

Unmerged revisions

2457. By Paramjit Singh Sahota(OpenERP)

[FIX][Trunk/6.1] view update on selection change.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2012-05-16 14:52:31 +0000
3+++ addons/web/static/src/js/view_form.js 2012-05-21 12:54:03 +0000
4@@ -1385,6 +1385,8 @@
5 this.$element.hide();
6 } else {
7 this.$element.show();
8+ this.$element.addClass('ui-state-active');
9+ this.$element.removeClass('ui-tabs-hide');
10 }
11 };
12 this.on("change:effective_invisible", this, check_visibility);