Odoo Web (MOVED TO GITHUB)

Merge lp:~openerp-commiter/openerp-web/trunk-bug-987745-ggh into lp:openerp-web

  1. trunk-bug-987745-ggh
  2. Merge into trunk
Proposed by Nicolas Vanhoren (OpenERP)
Status: Rejected
Rejected by: Nicolas Vanhoren (OpenERP)
Proposed branch: lp:~openerp-commiter/openerp-web/trunk-bug-987745-ggh
Merge into: lp:openerp-web
Diff against target: 12 lines (+1/-1)
1 file modified
addons/web/static/src/js/view_form.js (+1/-1)
To merge this branch: bzr merge lp:~openerp-commiter/openerp-web/trunk-bug-987745-ggh
Reviewer Review Type Date Requested Status
Nicolas Vanhoren (OpenERP) (community) Disapprove
Review via email: mp+109086@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

This is not a correct way to do it. Date(time) widgets should use javascript date objects internally and use the formatting functions to convert to OpenERP format and displayable format.

review: Disapprove

Unmerged revisions

2460. By Farid Ghanchi

[FIX] Fixed the issue of date widget not working properly.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web/static/src/js/view_form.js'
2--- addons/web/static/src/js/view_form.js 2012-06-05 16:16:10 +0000
3+++ addons/web/static/src/js/view_form.js 2012-06-07 08:38:27 +0000
4@@ -2000,7 +2000,7 @@
5 return $.fn[this.jqueryui_object].apply(this.$input_picker, arguments);
6 },
7 on_picker_select: function(text, instance_) {
8- var date = this.picker('getDate');
9+ var date = this.picker('getDate').toString("yyyy-MM-dd");
10 this.$input.val(date ? this.format_client(date) : '').change();
11 },
12 set_value: function(value_) {