Merge lp:~openerp-commiter/openerp-web/trunk-bug-985005-psa into lp:openerp-web

[Paramjit Singh Sahota(OpenERP)]

Hello,

   I have modified code for set and get readonly modifers.

Thanks & Regards,
PSA (Paramjit).

[Nicolas Vanhoren (OpenERP) (niv-openerp)]

Why would we want to handle the readonly property in buttons??? That has no sense, can you edit a button??

review: Disapprove

[Numérigraphe (numerigraphe)]

For what it's worth: in the GTK client, readonly buttons are displayed, inactive and grayed out. It does make sense.
Lionel.

Unmerged revisions

2491. By Paramjit Singh Sahota(OpenERP) on 2012-06-01

[FIX][Trunk] Attrs readonly condition works not properly.

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2012-05-31 16:06:12 +0000
+++ addons/web/static/src/js/view_form.js	2012-06-01 07:01:22 +0000
@@ -1510,6 +1510,7 @@
     init: function(view, node) {
         this._super(view, node);
         this.force_disabled = false;
+        this.set({"readonly": this.modifiers['readonly'] === true}); //setting the value to readonly
         this.string = (this.node.attrs.string || '').replace(/_/g, '');
         if (this.node.attrs.default_focus == '1') {
             // TODO fme: provide enter key binding to widgets
@@ -1583,8 +1584,8 @@
                 self.view.reload();
             });
     },
-    check_disable: function() {
-        var disabled = (this.force_disabled || !this.view.is_interactible_record());
+    check_disable: function() {        
+        var disabled = (this.get('readonly') || this.force_disabled || !this.view.is_interactible_record());
         this.$element.prop('disabled', disabled);
         this.$element.css('color', disabled ? 'grey' : '');
     }