Merge lp:~online-accounts/libsignon-glib/packaging into lp:libsignon-glib

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: no longer in the source branch.
Merged at revision: 152
Proposed branch: lp:~online-accounts/libsignon-glib/packaging
Merge into: lp:libsignon-glib
Diff against target: 93 lines (+17/-9)
5 files modified
debian/changelog (+7/-0)
libsignon-glib/signon-identity-info.c (+4/-3)
libsignon-glib/signon-identity.c (+2/-2)
libsignon-glib/signon.vapi (+3/-3)
tests/signon-glib-test.sh (+1/-1)
To merge this branch: bzr merge lp:~online-accounts/libsignon-glib/packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Online Accounts Pending
Review via email: mp+255082@code.launchpad.net

Commit message

Merge from upstream:

- Introspection: mark ACL and realms as string lists (LP: #1439695)

Description of the change

Merge from upstream:

- Introspection: mark ACL and realms as string lists (LP: #1439695)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
152. By Alberto Mardegan

Merge from upstream:

- Introspection: mark ACL and realms as string lists (LP: #1439695)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-12-09 13:48:27 +0000
3+++ debian/changelog 2015-04-10 07:30:42 +0000
4@@ -1,3 +1,10 @@
5+libsignon-glib (1.12+15.04.20141209-0ubuntu2) UNRELEASED; urgency=medium
6+
7+ * Merge from upstream:
8+ - Introspection: mark ACL and realms as string lists (LP: #1439695)
9+
10+ -- Alberto Mardegan <alberto.mardegan@canonical.com> Thu, 02 Apr 2015 16:28:45 +0300
11+
12 libsignon-glib (1.12+15.04.20141209-0ubuntu1) vivid; urgency=medium
13
14 [ Alberto Mardegan ]
15
16=== modified file 'libsignon-glib/signon-identity-info.c'
17--- libsignon-glib/signon-identity-info.c 2012-08-02 10:25:48 +0000
18+++ libsignon-glib/signon-identity-info.c 2015-04-10 07:30:42 +0000
19@@ -480,7 +480,7 @@
20 * signon_identity_info_set_method:
21 * @info: the #SignonIdentityInfo.
22 * @method: an authentication method.
23- * @mechanisms: a %NULL-termianted list of mechanisms.
24+ * @mechanisms: (transfer none) (type GStrv): a %NULL-termianted list of mechanisms.
25 *
26 * Adds a method to the list of allowed methods. If this method is not called
27 * even once, then all methods are allowed.
28@@ -518,7 +518,7 @@
29 /**
30 * signon_identity_info_set_realms:
31 * @info: the #SignonIdentityInfo.
32- * @realms: a %NULL-terminated list of realms.
33+ * @realms: (transfer none) (type GStrv): a %NULL-terminated list of realms.
34 *
35 * Specify what realms this identity can be used in.
36 */
37@@ -535,7 +535,8 @@
38 /**
39 * signon_identity_info_set_access_control_list:
40 * @info: the #SignonIdentityInfo.
41- * @access_control_list: a %NULL-terminated list of ACL security domains.
42+ * @access_control_list: (transfer none) (type GStrv): a %NULL-terminated list
43+ * of ACL security domains.
44 *
45 * Specifies the ACL for this identity. The actual meaning of the ACL depends
46 * on the security framework used by signond.
47
48=== modified file 'libsignon-glib/signon-identity.c'
49--- libsignon-glib/signon-identity.c 2013-04-15 09:48:50 +0000
50+++ libsignon-glib/signon-identity.c 2015-04-10 07:30:42 +0000
51@@ -722,8 +722,8 @@
52 * @store_secret: whether signond should store the password.
53 * @methods: (transfer none) (element-type utf8 GStrv): methods.
54 * @caption: caption.
55- * @realms: realms.
56- * @access_control_list: access control list.
57+ * @realms: (transfer none) (type GStrv): realms.
58+ * @access_control_list: (transfer none) (type GStrv): access control list.
59 * @type: the type of the identity.
60 * @cb: (scope async): callback.
61 * @user_data: user_data.
62
63=== modified file 'libsignon-glib/signon.vapi'
64--- libsignon-glib/signon.vapi 2014-12-05 07:15:03 +0000
65+++ libsignon-glib/signon.vapi 2015-04-10 07:30:42 +0000
66@@ -59,11 +59,11 @@
67 public bool get_storing_secret ();
68 public unowned string get_username ();
69 public void remove_method (string method);
70- public void set_access_control_list (string access_control_list);
71+ public void set_access_control_list ([CCode (array_length = false, array_null_terminated = true)] string[] access_control_list);
72 public void set_caption (string caption);
73 public void set_identity_type (Signon.IdentityType type);
74- public void set_method (string method, string mechanisms);
75- public void set_realms (string realms);
76+ public void set_method (string method, [CCode (array_length = false, array_null_terminated = true)] string[] mechanisms);
77+ public void set_realms ([CCode (array_length = false, array_null_terminated = true)] string[] realms);
78 public void set_secret (string secret, bool store_secret);
79 public void set_username (string username);
80 }
81
82=== modified file 'tests/signon-glib-test.sh'
83--- tests/signon-glib-test.sh 2012-11-29 12:00:52 +0000
84+++ tests/signon-glib-test.sh 2015-04-10 07:30:42 +0000
85@@ -18,7 +18,7 @@
86 # session
87 if command -v dbus-test-runner > /dev/null ; then
88 echo "Using dbus-test-runner"
89- dbus-test-runner -m 180 -t signond \
90+ dbus-test-runner -m 180 -t signond -r \
91 -t "$TEST_APP" -f com.google.code.AccountsSSO.SingleSignOn
92 else
93 echo "Using existing D-Bus session"

Subscribers

No one subscribed via source and target branches