Merge ~ondrak/ubuntu/+source/linux/+git/xenial:dtb-update into ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon

Proposed by Ondrej Kubik on 2018-05-23
Status: Needs review
Proposed branch: ~ondrak/ubuntu/+source/linux/+git/xenial:dtb-update
Merge into: ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon
Diff against target: 38 lines (+4/-4)
1 file modified
arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi (+4/-4)
Reviewer Review Type Date Requested Status
Paolo Pisati 2018-05-23 Disapprove on 2018-05-24
Review via email: mp+346754@code.launchpad.net

Commit message

UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED functionality

  Updating dragonboard 410c device tree LED definition to work properly on Ubuntu Core
  Use rfkill(0/1) for bluetooth and wifi LEDs
  setting LED1 as heartbeat
  setting LED4 as default-on

To post a comment you must log in.
Paolo Pisati (p-pisati) wrote :

I don't have write access to the kernel repository, only the stable team has it: resend it to the ubuntu kernel ml for review.

Plus, it's missing an LB bug and the Buglink.

review: Disapprove

Unmerged commits

c4eafeb... by Ondrej Kubik on 2018-05-16

UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED functionality

  Updating dragonboard 410c device tree LED definition to work properly on Ubuntu Core
  Use rfkill(0/1) for bluetooth and wifi LEDs
  setting LED1 as heartbeat
  setting LED4 as default-on

Signed-off-by: Ondrej Kubik <email address hidden>

4c4e1ee... by Stefan Bader on 2018-05-09

UBUNTU: Ubuntu-snapdragon-4.4.0-1093.98

Signed-off-by: Stefan Bader <email address hidden>

8591825... by Stefan Bader on 2018-05-09

UBUNTU: Start new release

Ignore: yes
Signed-off-by: Stefan Bader <email address hidden>

5c8ca59... by Stefan Bader on 2018-05-03

UBUNTU: Ubuntu-snapdragon-4.4.0-1092.97

Signed-off-by: Stefan Bader <email address hidden>

6ee18a0... by Khaled El Mously on 2018-04-27

UBUNTU: Start new release

Ignore: yes
Signed-off-by: Stefan Bader <email address hidden>

9483d59... by Kleber Sacilotto de Souza on 2018-04-13

UBUNTU: Ubuntu-snapdragon-4.4.0-1090.95

Signed-off-by: Kleber Sacilotto de Souza <email address hidden>

75f1321... by Paolo Pisati on 2018-04-13

UBUNTU: [Config] arm64: disable BPF_JIT_ALWAYS_ON

BugLink: https://bugs.launchpad.net/bugs/1763644

Signed-off-by: Paolo Pisati <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Acked-by: Kleber Sacilotto de Souza <email address hidden>
Signed-off-by: Kleber Sacilotto de Souza <email address hidden>

1f32f3c... by Kleber Sacilotto de Souza on 2018-04-13

UBUNTU: Start new release

Ignore: yes
Signed-off-by: Kleber Sacilotto de Souza <email address hidden>

f4dc687... by Khaled El Mously on 2018-04-06

UBUNTU: Ubuntu-snapdragon-4.4.0-1089.94

Signed-off-by: Khalid Elmously <email address hidden>

6c1b2e4... by Khaled El Mously on 2018-04-06

UBUNTU: Start new release

Ignore: yes
Signed-off-by: Khalid Elmously <email address hidden>

Update scan failed

At least one of the branches involved have failed to scan. You can manually schedule a rescan if required.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
2index 68b3c75..56c63ce 100644
3--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
4+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
5@@ -218,7 +218,7 @@
6
7 led@1 {
8 label = "apq8016-sbc:green:user1";
9- gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
10+ gpios = <&msmgpio 95 GPIO_ACTIVE_HIGH>;
11 linux,default-trigger = "heartbeat";
12 default-state = "off";
13 };
14@@ -240,21 +240,21 @@
15 led@4 {
16 label = "apq8016-sbc:green:user4";
17 gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
18- linux,default-trigger = "none";
19+ linux,default-trigger = "default-on";
20 default-state = "off";
21 };
22
23 led@5 {
24 label = "apq8016-sbc:yellow:wlan";
25 gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
26- linux,default-trigger = "wlan";
27+ linux,default-trigger = "rfkill1";
28 default-state = "off";
29 };
30
31 led@6 {
32 label = "apq8016-sbc:blue:bt";
33 gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
34- linux,default-trigger = "bt";
35+ linux,default-trigger = "rfkill0";
36 default-state = "off";
37 };
38 };

Subscribers

People subscribed via source and target branches