interfaces/microstack-support: set controlsDeviceCgroup to true (#10975)
* interfaces/microstack-support: set controlsDeviceCgroup to true
This will prevent us from generating any udev rules which in turn should
entirely disable the enforcement of the device cgroup for processes in the
snap.
This is justified by the snap already managing cgroups of its containers and
VM's with the Delegate=true setting in serviceSnippets.
See also LP bug: https://bugs.launchpad.net/snapd/+bug/1892895 which is
partially addressed by this commit, specifically for the microstack snap which
uses the microstack-support interface.
Signed-off-by: Ian Johnson <email address hidden>
* tests: add spread test for microstack cgroup delegation
* tests/main/interfaces-microstack-support: use snap restart
This fixes the test by making it fail on master without the change to use
controlsDeviceCgroup, but passes in the branch enabling that for the interface.
Signed-off-by: Ian Johnson <email address hidden>
* tests: fix microstack-support test for cgroup v2
* i/b/microstack_support: add comment about delegation
* tests/microstack: make the service more verbose
Making the service more verbose might help debugging; these lines will
end up in journald.
* interfaces/udev/spec.go: leave TODO about cgroup interaction w/ Delegate=true
Signed-off-by: Ian Johnson <email address hidden>
Co-authored-by: Alberto Mardegan <email address hidden>
/usr/sbin/netplan is a Python wrapper around the netplan generator. The
generator binary itself is located in /usr/lib/netplan/generate and is
executed as a subprocess by its Python wrapper.
Currently a call to /usr/sbin/netplan generate fails with the following
errors:
.github/workflows/test.yaml: restore failing of spread tests on errors (nested)
Merge pull request #11114 from anonymouse64/bugfix/no-pipefail-strikes-again
We need to use pipefail, otherwise the piping to tee will mean that the exit
code is always 0 and thus never actually fails the GitHub Action even when the
spread tests fail.
Merge pull request #11082 from anonymouse64/feature/uc20-multi-volume-gadget-asset-updates-29
gadget: tweaks to DiskStructureDeviceTraits + expand test cases
After working on DOS disks again I realized we left out a couple settings, and
that we don't need to include the ID, since it is a bit ambiguous and difficult to
compare between two hypothetical devices.
