Code review comment for lp:~ondrak/goget-ubuntu-touch/new-adb

Revision history for this message
Ondrej Kubik (ondrak) wrote :

I guess it's safe to say this is false warning, considering it's complaining about files that were not touched by this MP...

> The attempt to merge lp:~w-ondra/goget-ubuntu-touch/new-adb into lp:goget-
> ubuntu-touch failed. Below is the output from the failed tests.
>
> Checking formatting
> Formatting wrong in following files
> diskimage/bootloader.go diskimage/common.go diskimage/core_grub.go
> diskimage/core_uboot.go
>
>
> # we always run in a fresh dir in tarmac
> export GOPATH=$(mktemp -d)
> trap 'rm -rf "$GOPATH"' EXIT
>
> # this is a hack, but not sure tarmac is golang friendly
> mkdir -p $GOPATH/src/launchpad.net/goget-ubuntu-touch
> cp -a . $GOPATH/src/launchpad.net/goget-ubuntu-touch
> cd $GOPATH/src/launchpad.net/goget-ubuntu-touch
>
> ./run-checks

« Back to merge proposal