Merge ~omattos/ubuntu/+source/initramfs-tools:omattos-resume-battery-level into ubuntu/+source/initramfs-tools:ubuntu/devel

[Oliver Mattos]

Check battery level before resume from hibernate.

[Oliver Mattos (omattos)]

Any update on this?

[Michael Hudson-Doyle (mwhudson)]

Hi, this looks almost right although I'm not sure the logic is 100% right. I'm also not sure who really should be reviewing this though -- desktop maybe? Is there a bug report about this that should be referenced?

[Steve Langasek (vorlon)]

Michael posted comments on the diff that have not been addressed. Marking as such.

review: Needs Fixing

[Oliver Mattos (omattos)]

Since making this and using it for ~2 years, I have discovered a few laptop models which have buggy battery state reporting mechanisms. They can stop updating the OS as to the battery state and level (I suspect because the embedded controller has crashed? - or maybe dodgy connections to a removable battery).

Anyway - the end result is that this patch makes those models of laptop unusable, because even when the user plugs in a power supply, the battery remains in the "3% charge, discharging, no AC" state, and the system won't boot.

This patch is therefore on hold until someone adds some kind of way to easily bypass the warning, and that requires plymouth to have better support for user interaction.

Unmerged commits

7cd1108... by Oliver Mattos <email address hidden> on 2021-02-02

Check battery level before resume from hibernate.

Issue: If an Ubuntu laptop has a battery get to a critical low level, it
will hibernate eventually.

If the system is then powered on again without being recharged, the resume
process will occur and the system will run out of battery a few seconds later.
This destroys the users state.

This patch causes the resume to be delayed until the battery is no longer
discharging and at a low level. The user will be notified on the boot
screen, and the resume process will auto-continue if a power supply is
attached.

84fbfef... by Guilherme G. Piccoli on 2020-08-31

0.137ubuntu12 (patches unapplied)

Imported using git-ubuntu import.

6119d3f... by Guilherme G. Piccoli on 2020-08-03

0.137ubuntu11 (patches unapplied)

Imported using git-ubuntu import.

d7c7790... by Alfonso Sanchez-Beato on 2020-05-27

0.137ubuntu10 (patches unapplied)

Imported using git-ubuntu import.

66eec50... by Dimitri John Ledkov on 2020-05-30

0.137ubuntu9 (patches unapplied)

Imported using git-ubuntu import.

1f65bf8... by Dimitri John Ledkov on 2020-05-30

0.137ubuntu8 (patches unapplied)

Imported using git-ubuntu import.

1ab0970... by Dimitri John Ledkov on 2020-05-29

0.137ubuntu7 (patches unapplied)

Imported using git-ubuntu import.

98abf31... by Gianfranco Costamagna on 2020-05-27

0.137ubuntu6 (patches unapplied)

Imported using git-ubuntu import.

8b13d3c... by Dimitri John Ledkov on 2020-05-26

0.137ubuntu5 (patches unapplied)

Imported using git-ubuntu import.

e61ba3c... by Gianfranco Costamagna on 2020-05-20

0.137ubuntu4 (patches unapplied)

Imported using git-ubuntu import.

diff --git a/scripts/local-premount/resume b/scripts/local-premount/resume
index 272a728..bc087b8 100755
--- a/scripts/local-premount/resume
+++ b/scripts/local-premount/resume
@@ -19,6 +19,29 @@ if [ -z "${resume?}" ] || [ ! -e /sys/power/resume ]; then
 	exit 0
 fi
 
+wait_on_low_battery()
+{
+  while true; do
+    supply_is_good=true
+    for supply in /sys/class/power_supply/*; do
+      [ -f "${supply}/status" ] || continue
+      [ -f "${supply}/capacity" ] || continue
+      grep -q Discharging "${supply}/status" || continue
+      [ `cat ${supply}/capacity` -lt 5 ] || continue
+      supply_is_good=false
+    done
+    if "$supply_is_good"; then
+      break
+    fi
+    if [ "$use_plymouth" == "true" ]; then
+      plymouth message --text="Battery Low.  Please plug in to continue."
+    else
+      echo "Battery Low.  Please plug in to continue."
+    fi
+    sleep 1
+  done
+}
+
 . /scripts/functions
 . /scripts/local
 
@@ -56,6 +79,8 @@ fi
 
 case "${SWAPTYPE}" in
     swsuspend|s1suspend|s2suspend|ulsuspend|tuxonice)
+        wait_on_low_battery
+
 	if "$use_plymouth"; then
 		plymouth message --text="Resuming from $resume"