MVHub

Merge lp:~omacneil/mvhub/fix_some_purposes into lp:mvhub

  1. fix_some_purposes
  2. Merge into trunk_2format
Proposed by Dan MacNeil
Status: Merged
Merged at revision: 624
Proposed branch: lp:~omacneil/mvhub/fix_some_purposes
Merge into: lp:mvhub
Diff against target: 367 lines (+38/-34)
26 files modified
README (+2/-1)
app-mvhub/t/header_doc_existence.t (+1/-1)
lib-mvhub/t/00-setup.t (+2/-1)
lib-mvhub/t/01-load.t (+0/-2)
lib-mvhub/t/AgencyAccount/new.t (+1/-2)
lib-mvhub/t/AuthAccount/_die_loudly_if_dir_not_writable.t (+1/-1)
lib-mvhub/t/Headings/categories.t (+1/-1)
lib-mvhub/t/Headings/heading_names.t (+1/-1)
lib-mvhub/t/Notifications/create_final_notification_emails_with.t (+2/-1)
lib-mvhub/t/Notifications/create_fourth_notification_emails_with.t (+1/-1)
lib-mvhub/t/Notifications/create_notifications_using.t (+2/-1)
lib-mvhub/t/Notifications/create_standard_notification_emails_with.t (+2/-1)
lib-mvhub/t/Notifications/die_if_record_count_mismatch.t (+2/-1)
lib-mvhub/t/Notifications/get_email_constants_from.t (+1/-1)
lib-mvhub/t/Notifications/get_expired_records.t (+1/-2)
lib-mvhub/t/Notifications/increment_reminder_levels_for.t (+1/-1)
lib-mvhub/t/Notifications/print_emails_contained_in.t (+2/-1)
lib-mvhub/t/Notifications/send_emails_contained_in.t (+1/-1)
lib-mvhub/t/Notifications/set_reminder_level_in_db.t (+1/-1)
lib-mvhub/t/Notifications/shift_off_notifications_with_reminder_count.t (+3/-1)
lib-mvhub/t/ProgramFieldDefs/get_program_field_definitions_href.t (+3/-1)
lib-mvhub/t/Synonyms/fetch_synonyms_from_db.t (+1/-1)
lib-mvhub/t/Synonyms/submit_synonyms_to_db.t (+2/-1)
lib-mvhub/t/Utils/parse_zip_code.t (+1/-1)
lib-mvhub/t/conf/all.conf (+2/-6)
lib-mvhub/t/conf/perltidyrc (+1/-1)
To merge this branch: bzr merge lp:~omacneil/mvhub/fix_some_purposes
Reviewer Review Type Date Requested Status
MVHub devs with commit rights Pending
Review via email: mp+141228@code.launchpad.net

Description of the change

filled in PURPOSE for a few files

To post a comment you must log in.
lp:~omacneil/mvhub/fix_some_purposes updated
624. By Dan MacNeil

merged fix_some_purposes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2011-12-02 15:08:42 +0000
3+++ README 2012-12-24 17:24:22 +0000
4@@ -4,7 +4,8 @@
5 # CONTACT: help@thecsl.org
6 # PROJECT: https://launchpad.net/mvhub/
7
8-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
9+# PURPOSE: Get programmer / installer started on using MVHub software
10+
11 DESCRIPTION
12
13 MVHub is a web based directory of community services
14
15=== modified file 'app-mvhub/t/header_doc_existence.t'
16--- app-mvhub/t/header_doc_existence.t 2012-03-20 02:44:08 +0000
17+++ app-mvhub/t/header_doc_existence.t 2012-12-24 17:24:22 +0000
18@@ -5,7 +5,7 @@
19 # CONTACT: help@thecsl.org
20 # PROJECT: https://launchpad.net/mvhub/
21
22-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
23+# PURPOSE: Confirm that each text file has LICENSE/COPYRIGHT/CONtACT/PROJECT/PURPOSE
24
25 use strict;
26 use warnings;
27
28=== modified file 'lib-mvhub/t/00-setup.t'
29--- lib-mvhub/t/00-setup.t 2011-12-02 15:08:42 +0000
30+++ lib-mvhub/t/00-setup.t 2012-12-24 17:24:22 +0000
31@@ -5,7 +5,8 @@
32 # CONTACT: help@thecsl.org
33 # PROJECT: https://launchpad.net/mvhub/
34
35-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
36+# PURPOSE: check the enviroment vars are set, that we can create a test db a
37+# and add test data to it
38
39 use strict;
40 use warnings;
41
42=== modified file 'lib-mvhub/t/01-load.t'
43--- lib-mvhub/t/01-load.t 2011-12-02 15:08:42 +0000
44+++ lib-mvhub/t/01-load.t 2012-12-24 17:24:22 +0000
45@@ -5,8 +5,6 @@
46 # CONTACT: help@thecsl.org
47 # PROJECT: https://launchpad.net/mvhub/
48
49-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
50-
51 # PURPOSE: do a 'use MVHub::ModuleName' on all our produciton modules
52
53 use strict;
54
55=== modified file 'lib-mvhub/t/AgencyAccount/new.t'
56--- lib-mvhub/t/AgencyAccount/new.t 2011-12-02 15:08:42 +0000
57+++ lib-mvhub/t/AgencyAccount/new.t 2012-12-24 17:24:22 +0000
58@@ -5,13 +5,12 @@
59 # CONTACT: help@thecsl.org
60 # PROJECT: https://launchpad.net/mvhub/
61
62-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
63+# PURPOSE: test we can run create a AgencyAccount object and call its methods
64
65 use strict;
66 use warnings;
67 use Test::NoWarnings;
68
69-# EDIT
70 use Test::More tests => 3;
71 use CGI;
72 use MVHub::AgencyAccount;
73
74=== modified file 'lib-mvhub/t/AuthAccount/_die_loudly_if_dir_not_writable.t'
75--- lib-mvhub/t/AuthAccount/_die_loudly_if_dir_not_writable.t 2011-12-02 15:08:42 +0000
76+++ lib-mvhub/t/AuthAccount/_die_loudly_if_dir_not_writable.t 2012-12-24 17:24:22 +0000
77@@ -5,7 +5,7 @@
78 # CONTACT: help@thecsl.org
79 # PROJECT: https://launchpad.net/mvhub/
80
81-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
82+# PURPOSE: test sub that dies if dir isn't writeable
83
84 use strict;
85 use warnings;
86
87=== modified file 'lib-mvhub/t/Headings/categories.t'
88--- lib-mvhub/t/Headings/categories.t 2011-12-02 15:08:42 +0000
89+++ lib-mvhub/t/Headings/categories.t 2012-12-24 17:24:22 +0000
90@@ -5,7 +5,7 @@
91 # CONTACT: help@thecsl.org
92 # PROJECT: https://launchpad.net/mvhub/
93
94-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
95+# PURPOSE: test we can pull names of links in categories page
96
97 use strict;
98 use warnings;
99
100=== modified file 'lib-mvhub/t/Headings/heading_names.t'
101--- lib-mvhub/t/Headings/heading_names.t 2011-12-02 15:08:42 +0000
102+++ lib-mvhub/t/Headings/heading_names.t 2012-12-24 17:24:22 +0000
103@@ -5,7 +5,7 @@
104 # CONTACT: help@thecsl.org
105 # PROJECT: https://launchpad.net/mvhub/
106
107-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
108+# PURPOSE: test we can pull names of links used in headings page
109
110 use strict;
111 use warnings;
112
113=== modified file 'lib-mvhub/t/Notifications/create_final_notification_emails_with.t'
114--- lib-mvhub/t/Notifications/create_final_notification_emails_with.t 2011-12-02 15:08:42 +0000
115+++ lib-mvhub/t/Notifications/create_final_notification_emails_with.t 2012-12-24 17:24:22 +0000
116@@ -5,7 +5,8 @@
117 # CONTACT: help@thecsl.org
118 # PROJECT: https://launchpad.net/mvhub/
119
120-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
121+# PURPOSE: test we can create the object used to generate the final
122+# reminder email
123
124 use strict;
125 use warnings;
126
127=== modified file 'lib-mvhub/t/Notifications/create_fourth_notification_emails_with.t'
128--- lib-mvhub/t/Notifications/create_fourth_notification_emails_with.t 2011-12-02 15:08:42 +0000
129+++ lib-mvhub/t/Notifications/create_fourth_notification_emails_with.t 2012-12-24 17:24:22 +0000
130@@ -5,7 +5,7 @@
131 # CONTACT: help@thecsl.org
132 # PROJECT: https://launchpad.net/mvhub/
133
134-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
135+# PURPOSE: test sub that creates 4th notify email runs and accepts params
136
137 use strict;
138 use warnings;
139
140=== modified file 'lib-mvhub/t/Notifications/create_notifications_using.t'
141--- lib-mvhub/t/Notifications/create_notifications_using.t 2011-12-02 15:08:42 +0000
142+++ lib-mvhub/t/Notifications/create_notifications_using.t 2012-12-24 17:24:22 +0000
143@@ -5,7 +5,8 @@
144 # CONTACT: help@thecsl.org
145 # PROJECT: https://launchpad.net/mvhub/
146
147-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
148+# PURPOSE: test sub used to create notification records from
149+# out of date program and agency records
150
151 use strict;
152 use warnings;
153
154=== modified file 'lib-mvhub/t/Notifications/create_standard_notification_emails_with.t'
155--- lib-mvhub/t/Notifications/create_standard_notification_emails_with.t 2011-12-02 15:08:42 +0000
156+++ lib-mvhub/t/Notifications/create_standard_notification_emails_with.t 2012-12-24 17:24:22 +0000
157@@ -5,7 +5,8 @@
158 # CONTACT: help@thecsl.org
159 # PROJECT: https://launchpad.net/mvhub/
160
161-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
162+# PURPOSE: test we can create the body/subject/to for an email
163+# notifying a person their record is out of date
164
165 use strict;
166 use warnings;
167
168=== modified file 'lib-mvhub/t/Notifications/die_if_record_count_mismatch.t'
169--- lib-mvhub/t/Notifications/die_if_record_count_mismatch.t 2011-12-02 15:08:42 +0000
170+++ lib-mvhub/t/Notifications/die_if_record_count_mismatch.t 2012-12-24 17:24:22 +0000
171@@ -5,7 +5,8 @@
172 # CONTACT: help@thecsl.org
173 # PROJECT: https://launchpad.net/mvhub/
174
175-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
176+# PURPOSE: test sub that sanity checks that we have a notification
177+# for each record we pass in
178
179 use strict;
180 use warnings;
181
182=== modified file 'lib-mvhub/t/Notifications/get_email_constants_from.t'
183--- lib-mvhub/t/Notifications/get_email_constants_from.t 2011-12-02 15:08:42 +0000
184+++ lib-mvhub/t/Notifications/get_email_constants_from.t 2012-12-24 17:24:22 +0000
185@@ -5,7 +5,7 @@
186 # CONTACT: help@thecsl.org
187 # PROJECT: https://launchpad.net/mvhub/
188
189-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
190+# PURPOSE: test we retrieved constants needed to send email
191
192 use strict;
193 use warnings;
194
195=== modified file 'lib-mvhub/t/Notifications/get_expired_records.t'
196--- lib-mvhub/t/Notifications/get_expired_records.t 2011-12-02 15:08:42 +0000
197+++ lib-mvhub/t/Notifications/get_expired_records.t 2012-12-24 17:24:22 +0000
198@@ -5,13 +5,12 @@
199 # CONTACT: help@thecsl.org
200 # PROJECT: https://launchpad.net/mvhub/
201
202-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
203+# PURPOSE: test sub that returns list of out of date records
204
205 use strict;
206 use warnings;
207 use Carp;
208
209-# EDIT
210 use Test::More tests => 3 + 1; # +1 for NoWarnings
211 use Test::NoWarnings;
212 use Test::Exception;
213
214=== modified file 'lib-mvhub/t/Notifications/increment_reminder_levels_for.t'
215--- lib-mvhub/t/Notifications/increment_reminder_levels_for.t 2011-12-02 15:08:42 +0000
216+++ lib-mvhub/t/Notifications/increment_reminder_levels_for.t 2012-12-24 17:24:22 +0000
217@@ -5,7 +5,7 @@
218 # CONTACT: help@thecsl.org
219 # PROJECT: https://launchpad.net/mvhub/
220
221-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
222+# PURPOSE: test sub that increments count of reminders sent for a record
223
224 use strict;
225 use warnings;
226
227=== modified file 'lib-mvhub/t/Notifications/print_emails_contained_in.t'
228--- lib-mvhub/t/Notifications/print_emails_contained_in.t 2011-12-02 15:08:42 +0000
229+++ lib-mvhub/t/Notifications/print_emails_contained_in.t 2012-12-24 17:24:22 +0000
230@@ -5,7 +5,8 @@
231 # CONTACT: help@thecsl.org
232 # PROJECT: https://launchpad.net/mvhub/
233
234-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
235+# PURPOSE: test sub that provides preview / test print of
236+# reminder emails
237
238 use strict;
239 use warnings;
240
241=== modified file 'lib-mvhub/t/Notifications/send_emails_contained_in.t'
242--- lib-mvhub/t/Notifications/send_emails_contained_in.t 2011-12-02 15:08:42 +0000
243+++ lib-mvhub/t/Notifications/send_emails_contained_in.t 2012-12-24 17:24:22 +0000
244@@ -5,7 +5,7 @@
245 # CONTACT: help@thecsl.org
246 # PROJECT: https://launchpad.net/mvhub/
247
248-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
249+# PURPOSE: test we can send emails
250
251 use strict;
252 use warnings;
253
254=== modified file 'lib-mvhub/t/Notifications/set_reminder_level_in_db.t'
255--- lib-mvhub/t/Notifications/set_reminder_level_in_db.t 2011-12-02 15:08:42 +0000
256+++ lib-mvhub/t/Notifications/set_reminder_level_in_db.t 2012-12-24 17:24:22 +0000
257@@ -5,7 +5,7 @@
258 # CONTACT: help@thecsl.org
259 # PROJECT: https://launchpad.net/mvhub/
260
261-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
262+# PURPOSE: test sub that increments count of reminders sent for a record
263
264 use strict;
265 use warnings;
266
267=== modified file 'lib-mvhub/t/Notifications/shift_off_notifications_with_reminder_count.t'
268--- lib-mvhub/t/Notifications/shift_off_notifications_with_reminder_count.t 2011-12-02 15:08:42 +0000
269+++ lib-mvhub/t/Notifications/shift_off_notifications_with_reminder_count.t 2012-12-24 17:24:22 +0000
270@@ -5,7 +5,9 @@
271 # CONTACT: help@thecsl.org
272 # PROJECT: https://launchpad.net/mvhub/
273
274-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
275+# PURPOSE: test sub used to extrct records that haven't been updated
276+# and who's users have recieved n reminders this list is feed
277+# to reminder emails and phone calls
278
279 use strict;
280 use warnings;
281
282=== modified file 'lib-mvhub/t/ProgramFieldDefs/get_program_field_definitions_href.t'
283--- lib-mvhub/t/ProgramFieldDefs/get_program_field_definitions_href.t 2011-12-02 15:08:42 +0000
284+++ lib-mvhub/t/ProgramFieldDefs/get_program_field_definitions_href.t 2012-12-24 17:24:22 +0000
285@@ -5,7 +5,9 @@
286 # CONTACT: help@thecsl.org
287 # PROJECT: https://launchpad.net/mvhub/
288
289-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
290+# PURPOSE: test we get retrieve html form field names, types for the
291+# add/edit program form
292+
293 use strict;
294 use warnings;
295
296
297=== modified file 'lib-mvhub/t/Synonyms/fetch_synonyms_from_db.t'
298--- lib-mvhub/t/Synonyms/fetch_synonyms_from_db.t 2011-12-02 15:08:42 +0000
299+++ lib-mvhub/t/Synonyms/fetch_synonyms_from_db.t 2012-12-24 17:24:22 +0000
300@@ -5,7 +5,7 @@
301 # CONTACT: help@thecsl.org
302 # PROJECT: https://launchpad.net/mvhub/
303
304-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
305+# PURPOSE: test we get synoymns out of databsae as we got them in
306
307 use strict;
308 use warnings;
309
310=== modified file 'lib-mvhub/t/Synonyms/submit_synonyms_to_db.t'
311--- lib-mvhub/t/Synonyms/submit_synonyms_to_db.t 2011-12-02 15:08:42 +0000
312+++ lib-mvhub/t/Synonyms/submit_synonyms_to_db.t 2012-12-24 17:24:22 +0000
313@@ -5,7 +5,8 @@
314 # CONTACT: help@thecsl.org
315 # PROJECT: https://launchpad.net/mvhub/
316
317-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
318+# PURPOSE: test that we get back the synonyms back that we sent to the database
319+# synonyms allow user to find 'alcohol' programs by searching for 'drunk'
320
321 use strict;
322 use warnings;
323
324=== modified file 'lib-mvhub/t/Utils/parse_zip_code.t'
325--- lib-mvhub/t/Utils/parse_zip_code.t 2011-12-02 15:08:42 +0000
326+++ lib-mvhub/t/Utils/parse_zip_code.t 2012-12-24 17:24:22 +0000
327@@ -5,7 +5,7 @@
328 # CONTACT: help@thecsl.org
329 # PROJECT: https://launchpad.net/mvhub/
330
331-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
332+# PURPOSE: test sub that validates zip codes
333
334 use strict;
335 use Test::More tests => 9;
336
337=== modified file 'lib-mvhub/t/conf/all.conf'
338--- lib-mvhub/t/conf/all.conf 2011-12-02 15:08:42 +0000
339+++ lib-mvhub/t/conf/all.conf 2012-12-24 17:24:22 +0000
340@@ -4,12 +4,8 @@
341 # CONTACT: help@thecsl.org
342 # PROJECT: https://launchpad.net/mvhub/
343
344-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
345-
346-# Configuration file for the Directory Services Guide application
347-
348-# All parameters are required unless otherwise stated. This is not currently
349-# enforced in any way, so please cooperate.
350+# PURPOSE: config file used for test scripts, theoretically common elements
351+# between nsp.conf and mvh.conf
352
353 [DATABASE]
354 # not needed for sqlite
355
356=== modified file 'lib-mvhub/t/conf/perltidyrc'
357--- lib-mvhub/t/conf/perltidyrc 2011-12-02 15:08:42 +0000
358+++ lib-mvhub/t/conf/perltidyrc 2012-12-24 17:24:22 +0000
359@@ -4,7 +4,7 @@
360 # CONTACT: help@thecsl.org
361 # PROJECT: https://launchpad.net/mvhub/
362
363-# PURPOSE: MEANINGFUL PURPOSE IS REQUIRED!!
364+# PURPOSE: configure perltidy , used to format our Perl code
365 # PBP .perltidyrc file
366
367 -l=78 # Max line width is 78 cols

Subscribers

People subscribed via source and target branches