Merge lp:~om26er/webbrowser-app/activity_close_button_left into lp:webbrowser-app

Proposed by Omer Akram
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 396
Merged at revision: 410
Proposed branch: lp:~om26er/webbrowser-app/activity_close_button_left
Merge into: lp:webbrowser-app
Diff against target: 14 lines (+2/-2)
1 file modified
src/app/PageDelegate.qml (+2/-2)
To merge this branch: bzr merge lp:~om26er/webbrowser-app/activity_close_button_left
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
Review via email: mp+192533@code.launchpad.net

Commit message

move the close button of the running activity to the left.

Description of the change

the close button is on the left in Ubuntu. A similar change was done in unity8 as well (bug 1236285)

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good, thanks for the update!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:396
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/506/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/78
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/77
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/8
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/69
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/78
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/78/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/77
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/77/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2704
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2755
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/450
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/440

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webbrowser-app-ci/506/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/324/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/79/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/78
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-autolanding/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/4
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-autolanding/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-autolanding/4
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/70/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/79
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/79/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/78
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/78/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2705
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2756
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/451
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/441

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:396
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/526/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/561
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/549
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/28
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/516
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/561
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/561/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/549
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/549/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/3014
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3196
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1212
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1211

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webbrowser-app-ci/526/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/PageDelegate.qml'
2--- src/app/PageDelegate.qml 2013-10-03 10:57:37 +0000
3+++ src/app/PageDelegate.qml 2013-10-24 15:52:32 +0000
4@@ -97,8 +97,8 @@
5 anchors {
6 top: parent.top
7 topMargin: -units.gu(1)
8- right: parent.right
9- rightMargin: -units.gu(1)
10+ left: parent.left
11+ leftMargin: -units.gu(1)
12 }
13
14 Image {

Subscribers

People subscribed via source and target branches

to status/vote changes: