Merge lp:~om26er/unity8/show_password_on_label_tap into lp:unity8

[Omer Akram]

show password when tapped on the 'Show password' label, not just the checkbox.

show password when tapped on the 'Show password' label, not just the checkbox.

[lp:~om26er/unity8/show_password_on_label_tap]

1398. By Omer Akram on 2014-11-05

fix as Saviq suggested

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1397
http://jenkins.qa.ubuntu.com/job/unity8-ci/4831/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6492/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1817/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1927/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1925/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7744/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4831/rebuild

review: Needs Fixing (continuous-integration)

[lp:~om26er/unity8/show_password_on_label_tap]

1399. By Omer Akram on 2014-11-05

need to have a MouseArea to click at

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1398
http://jenkins.qa.ubuntu.com/job/unity8-ci/4833/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6495/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1819/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1929/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1927/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7747/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4833/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1399
http://jenkins.qa.ubuntu.com/job/unity8-ci/4834/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6497/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1820/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1930/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1928/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7749/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4834/rebuild

review: Needs Fixing (continuous-integration)

[lp:~om26er/unity8/show_password_on_label_tap]

1400. By Omer Akram on 2014-11-05

merge trunk

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1400
http://jenkins.qa.ubuntu.com/job/unity8-ci/4835/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6499/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1821/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1931/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1929/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7751/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4835/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

Checklist please

review: Needs Fixing

[Michael Zanetti (mzanetti)]

See this wiki page on how to propose branches to unity8: https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8

This looks like it could need a test. Can you add one please? I guess it should be fine to add it into tst_Notifications.qml

review: Needs Fixing

[Michael Zanetti (mzanetti)]

Hm.. I just realized this is a snap decision notification with private-menu-hits which we don't really have a nice way to mock yet. I'm ok to go without tests here. Please add the checklist and we're good.

[lp:~om26er/unity8/show_password_on_label_tap]

1401. By Omer Akram on 2014-11-13

merge trunk

1402. By Omer Akram on 2014-11-13

fix tags

[Omer Akram (om26er)]

Are there any related MPs required for this MP to build/function as expected? Please list.
    No.

Did you perform an exploratory manual test run of your code change and any related
functionality?
    Yes.

Did you make sure that your branch does not contain spurious tags?
    Yes, ran Saviq's script.

If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
    No change.

If you changed the UI, has there been a design review?
    Not needed.

[Omer Akram (om26er)]

@Saviq, I ran your script over this branch.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1402
http://jenkins.qa.ubuntu.com/job/unity8-ci/4897/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/203
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/182
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/203/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15813

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4897/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1402
http://jenkins.qa.ubuntu.com/job/unity8-ci/4898/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/209
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/75
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/209
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/209/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15819

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4898/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

Branch has a lot of spurious tags.

review: Needs Fixing

[Michael Zanetti (mzanetti)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

yes

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

=== modified file 'qml/Notifications/NotificationMenuItemFactory.qml'
--- qml/Notifications/NotificationMenuItemFactory.qml	2014-11-05 15:23:43 +0000
+++ qml/Notifications/NotificationMenuItemFactory.qml	2014-11-13 20:31:44 +0000
@@ -127,6 +127,11 @@
                     anchors.verticalCenter: checkBox.verticalCenter
                     text: i18n.tr("Show password")
                     color: notification.sdFontColor
+
+                    MouseArea {
+                        anchors.fill: parent
+                        onClicked: { checkBox.checked = !checkBox.checked }
+                    }
                 }
             }
         }