Merge lp:~om26er/unity8/search_indicator_dash_only into lp:unity8

Proposed by Omer Akram
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 456
Merged at revision: 457
Proposed branch: lp:~om26er/unity8/search_indicator_dash_only
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
Shell.qml (+1/-1)
To merge this branch: bzr merge lp:~om26er/unity8/search_indicator_dash_only
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
Review via email: mp+191012@code.launchpad.net

Commit message

Only show search indicator while the Dash is focued.

Description of the change

Only show search indicator while the Dash is focued.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Omer, thanks a lot for the fix. Mind adding a test for this too? I'm happy to help you with everything qmltest if you need that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Shell.qml'
2--- Shell.qml 2013-10-10 11:19:04 +0000
3+++ Shell.qml 2013-10-14 17:32:21 +0000
4@@ -579,7 +579,7 @@
5 contentEnabled: edgeDemo.panelContentEnabled
6 }
7 fullscreenMode: shell.fullscreenMode
8- searchVisible: !greeter.shown && !lockscreen.shown
9+ searchVisible: !greeter.shown && !lockscreen.shown && dash.shown
10
11 InputFilterArea {
12 anchors {

Subscribers

People subscribed via source and target branches