Merge lp:~om26er/unity8/launcher_integration_test into lp:unity8

[Omer Akram]

Autopilot: launch application from the launcher

Autopilot: launch application from the launcher

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:985
http://jenkins.qa.ubuntu.com/job/unity8-ci/3240/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1264/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/244/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/334/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/334/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/334/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2155/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3240/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:985
http://jenkins.qa.ubuntu.com/job/unity8-ci/3246/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1289
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/250
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/340
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/340
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/340/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/340
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1606
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2190
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2190/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8941

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3246/rebuild

review: Needs Fixing (continuous-integration)

[Víctor R. Ruiz (vrruiz)]

Please, use docstrings whenever possible. Specially, document a little bit what LauncherIcon class and its methods do.

review: Needs Fixing

[lp:~om26er/unity8/launcher_integration_test]

986. By Omer Akram on 2014-07-03

merge trunk

987. By Omer Akram on 2014-07-03

add docstring for fixture class.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:987
http://jenkins.qa.ubuntu.com/job/unity8-ci/3311/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1530
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/315
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/405
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/405
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/405/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/405
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1811
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2512
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2512/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9250

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3311/rebuild

review: Needs Fixing (continuous-integration)

[Víctor R. Ruiz (vrruiz)]

Sorry, Omer. Can you describe in docstrings what the _backup_launcher_icons, _set_launcher_icons and _add_messaging_app_icon_to_launcher do? Something like "Calls to blahblah via DBus to blahblahblah".

Also, if possible, for portability would be better to use dbus python module than doing calls to the system (what if gdbus command is not available?).

review: Needs Fixing

[Omer Akram (om26er)]

> Sorry, Omer. Can you describe in docstrings what the _backup_launcher_icons,
> _set_launcher_icons and _add_messaging_app_icon_to_launcher do? Something like
> "Calls to blahblah via DBus to blahblahblah".

They all are private methods, I don't think docstrings are necessary for them.
>
> Also, if possible, for portability would be better to use dbus python module
> than doing calls to the system (what if gdbus command is not available?).

Need to investigate more on that, can you give pointers on where to look, probably an example would help.

[Víctor R. Ruiz (vrruiz)]

There is a nice tutorial here: http://dbus.freedesktop.org/doc/dbus-python/doc/tutorial.html

[lp:~om26er/unity8/launcher_integration_test]

988. By Omer Akram on 2014-07-07

merge trunk

989. By Omer Akram on 2014-07-07

don't call gdbus, use the python api to talk to accountsservice.

990. By Omer Akram on 2014-07-07

change cleanUp call

[Omer Akram (om26er)]

> There is a nice tutorial here: http://dbus.freedesktop.org/doc/dbus-
> python/doc/tutorial.html

Thanks for that. Now I am using python for dbus call.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:990
http://jenkins.qa.ubuntu.com/job/unity8-ci/3357/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1651/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/361/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/451/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/451/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/451/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2675/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3357/rebuild

review: Needs Fixing (continuous-integration)

[lp:~om26er/unity8/launcher_integration_test]

991. By Omer Akram on 2014-07-08

Dummy commit for CI

992. By Omer Akram on 2014-07-08

fix crazy

993. By Omer Akram on 2014-07-08

give the messaging-app more time to start

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:991
http://jenkins.qa.ubuntu.com/job/unity8-ci/3362/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1684/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/456/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2724/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3362/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

Omer, please take a look at the existing branches in review before writing a new one, or consult with ubuntu-qa.
You duplicated some of the work I did here: https://code.launchpad.net/~elopio/unity8/test_open_app_from_launcher/+merge/225112

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:993
http://jenkins.qa.ubuntu.com/job/unity8-ci/3368/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1710/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/372/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/462/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/462/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/462/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2753/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3368/rebuild

review: Needs Fixing (continuous-integration)

[lp:~om26er/unity8/launcher_integration_test]

994. By Omer Akram on 2014-07-08

remove newly added test, seems some of that is already done elsewhere.

995. By Omer Akram on 2014-07-08

merge open_app_launcher test branch

996. By Omer Akram on 2014-07-09

merge trunk

Unmerged revisions

996. By Omer Akram on 2014-07-09

merge trunk

995. By Omer Akram on 2014-07-08

merge open_app_launcher test branch

994. By Omer Akram on 2014-07-08

remove newly added test, seems some of that is already done elsewhere.

993. By Omer Akram on 2014-07-08

give the messaging-app more time to start

992. By Omer Akram on 2014-07-08

fix crazy

991. By Omer Akram on 2014-07-08

Dummy commit for CI

990. By Omer Akram on 2014-07-07

change cleanUp call

989. By Omer Akram on 2014-07-07

don't call gdbus, use the python api to talk to accountsservice.

988. By Omer Akram on 2014-07-07

merge trunk

987. By Omer Akram on 2014-07-03

add docstring for fixture class.

=== modified file 'tests/autopilot/unity8/shell/emulators/launcher.py'
--- tests/autopilot/unity8/shell/emulators/launcher.py	2013-11-01 13:59:50 +0000
+++ tests/autopilot/unity8/shell/emulators/launcher.py	2014-07-08 12:32:48 +0000
@@ -36,3 +36,10 @@
         stop_y = start_y
         touch.drag(start_x, start_y, stop_x, stop_y)
         self.shown.wait_for(True)
+
+    def tap_icon(self, name):
+        """Tap an icon in the launcher."""
+        touch = Touch.create()
+
+        icon = self.select_single('LauncherDelegate', objectName=name)
+        touch.tap_object(icon)

=== modified file 'tests/autopilot/unity8/shell/fixture_setup.py'
--- tests/autopilot/unity8/shell/fixture_setup.py	2014-01-23 14:40:17 +0000
+++ tests/autopilot/unity8/shell/fixture_setup.py	2014-07-08 12:32:48 +0000
@@ -19,7 +19,9 @@
 
 """Set up and clean up fixtures for the Unity acceptance tests."""
 
+import dbus
 import os
+import subprocess
 import sysconfig
 
 import fixtures
@@ -51,3 +53,47 @@
                 'Expected library path does not exists: %s.' % (
                     ld_library_path))
         return ld_library_path
+
+
+class LauncherIcon(fixtures.Fixture):
+    """Fixture to setup launcher icons."""
+
+    def setUp(self):
+        super(LauncherIcon, self).setUp()
+        self._add_messaging_app_icon_to_launcher()
+
+    def _get_accounts_service_dbus_iface(self):
+        bus = dbus.SystemBus()
+        proxy = bus.get_object(
+            'org.freedesktop.Accounts',
+            '/org/freedesktop/Accounts/User32011')
+        return dbus.Interface(proxy, 'org.freedesktop.DBus.Properties')
+
+    def _backup_launcher_icons(self):
+        manager = self._get_accounts_service_dbus_iface()
+        self.backup = manager.Get(
+            'com.canonical.unity.AccountsService',
+            'launcher-items')
+        self.addCleanup(self._set_launcher_icons, self.backup)
+
+    def _set_launcher_icons(self, icons_config):
+        manager = self._get_accounts_service_dbus_iface()
+        manager.Set(
+            'com.canonical.unity.AccountsService',
+            'launcher-items', icons_config)
+
+    def _add_messaging_app_icon_to_launcher(self):
+        self._backup_launcher_icons()
+
+        messaging_icon = dbus.Array([dbus.Dictionary({
+        dbus.String('count'): dbus.Int32(0, variant_level=1),
+        dbus.String('countVisible'): dbus.Boolean(False, variant_level=1),
+        dbus.String('name'): dbus.String('Messaging', variant_level=1),
+        dbus.String('id'): dbus.String('messaging-app', variant_level=1),
+        dbus.String('icon'): dbus.String('image://theme/messaging-app',
+            variant_level=1)},
+        signature=dbus.Signature('sv'))],
+        signature=dbus.Signature('a{sv}'),
+        variant_level=1)
+        
+        self._set_launcher_icons(messaging_icon)

=== added file 'tests/autopilot/unity8/shell/tests/test_launcher.py'
--- tests/autopilot/unity8/shell/tests/test_launcher.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/unity8/shell/tests/test_launcher.py	2014-07-08 12:32:48 +0000
@@ -0,0 +1,54 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Unity Autopilot Test Suite
+# Copyright (C) 2014 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+"""Test for the Launcher."""
+
+from autopilot import platform
+from autopilot.matchers import Eventually
+from testtools import skipIf
+from testtools.matchers import Equals
+
+from unity8 import process_helpers
+from unity8.shell import tests, fixture_setup, disable_qml_mocking
+
+
+@skipIf(
+    platform.model() == 'Desktop',
+    'Needs platform APIs not available on desktop, yet.'
+)
+class LauncherTestCase(tests.UnityTestCase):
+
+    def setUp(self):
+        self.useFixture(fixture_setup.LauncherIcon())
+        super(LauncherTestCase, self).setUp()
+
+    @disable_qml_mocking
+    def test_launcher_opens_app(self):
+        """Make sure apps start from the launcher."""
+        self.unity_proxy = self.launch_unity()
+        process_helpers.unlock_unity(self.unity_proxy)
+
+        launcher = self.main_window.get_launcher()
+        launcher.show()
+        launcher.tap_icon('launcherDelegate0')
+
+        self.assertThat(
+            self.main_window.get_current_focused_app_id,
+            Eventually(Equals('messaging-app'), timeout=20)
+        )