Merge lp:~om26er/unity/update_click_outside_hud_dismiss into lp:unity

[Omer Akram]

Added the manual testcase bits into an already existing AP test. "Hud should close when mouse clicked outside of it"

Added the manual testcase bits into an already existing AP test. "Hud should close when mouse clicked outside of it"

This manual test case it seems is almost automated already, just added the part of typing text in the search bar and removing that with Escape.

If you want me to write a new test case instead of using an already written, I'll happily do that.

[Thomi Richards (thomir-deactivatedaccount)]

Hi Omer,

Please make this a new autopilot test. Tests should be as small as possible. In fact, if you see any large autopilot tests that can be split up, that's always a good thing to do (in a separate branch, of course).

Cheers,

review: Needs Fixing (quality)

Unmerged revisions

2575. By Omer Akram on 2012-08-18

update a AP and removed a manual case

=== modified file 'manual-tests/Hud.txt'
--- manual-tests/Hud.txt	2012-07-12 12:03:05 +0000
+++ manual-tests/Hud.txt	2012-08-18 12:21:23 +0000
@@ -35,22 +35,6 @@
   If the buttons under the search box do not highlight, this test failed.
 
 
-Hud Dismiss
-----------
-This test ensures that the hud is dismissable
-
-Setup:
-
-Actions:
-#. Tap Alt
-#. Type "test"
-#. Press escape
-#. Click anywhere on the screen that is not the hud interface
-
-Expected Result:
-  After pressing escape in step three, the text "test" should be removed from the hud search
-  After step four, the hud should dismiss itself and not be present.
-
 Alt+Arrow keys not passed to application
 ----------------------------------------
 Tests that Alt+ArrowKey events are correctly passed to the active window

=== modified file 'tests/autopilot/unity/tests/test_hud.py'
--- tests/autopilot/unity/tests/test_hud.py	2012-07-12 02:57:47 +0000
+++ tests/autopilot/unity/tests/test_hud.py	2012-08-18 12:21:23 +0000
@@ -230,6 +230,13 @@
         """
 
         self.hud.ensure_visible()
+        
+        self.keyboard.type("Test")
+        self.assertThat(self.hud.search_string, Eventually(Equals("Test")))
+        
+        self.keyboard.press_and_release("Escape")
+        self.assertThat(self.hud.search_string, Eventually(Equals("")))
+        
         (x,y,w,h) = self.hud.view.geometry
         self.mouse.move(w/2, h-50)
         self.mouse.click()