Merge lp:~om26er/unity/fix-778256 into lp:unity

Proposed by Omer Akram
Status: Merged
Approved by: Michal Hruby
Approved revision: 1835
Merged at revision: 1850
Proposed branch: lp:~om26er/unity/fix-778256
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/src/PanelTray.cpp (+1/-1)
To merge this branch: bzr merge lp:~om26er/unity/fix-778256
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Sam Spilsbury (community) Needs Fixing
Adolfo Jayme Barrientos (community) Approve
Review via email: mp+88594@code.launchpad.net

Description of the change

comment #27 bug 778256

"This bugfix got lost during the merge in revision 1361: http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/1361
It was fixed in revision 1228: http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/1228
The fix landed in June but this way it did not make it into Oneiric and is not part of the latest 5.0 release in Precise either.
Could any Ubuntu developer please check this out? It's a one liner change only."

To post a comment you must log in.
Revision history for this message
Adolfo Jayme Barrientos (fitojb) :
review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

@Omer, you can also do
nux::Geometry geo(GetAbsoluteGeometry());

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Yes, please do the above. Using operator= is premature pessimization.

review: Needs Fixing
lp:~om26er/unity/fix-778256 updated
1835. By Omer Akram

fix

Revision history for this message
Omer Akram (om26er) wrote :

done

Revision history for this message
Michal Hruby (mhr3) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/PanelTray.cpp'
2--- plugins/unityshell/src/PanelTray.cpp 2011-12-14 20:04:23 +0000
3+++ plugins/unityshell/src/PanelTray.cpp 2012-01-19 14:24:24 +0000
4@@ -114,7 +114,7 @@
5 void
6 PanelTray::Draw(nux::GraphicsEngine& gfx_context, bool force_draw)
7 {
8- nux::Geometry geo = GetGeometry();
9+ nux::Geometry geo(GetAbsoluteGeometry());
10
11 gfx_context.PushClippingRectangle(geo);
12 nux::GetPainter().PaintBackground(gfx_context, geo);