Merge lp:~om26er/ubuntu/maverick/gwibber/gwibber-fix-674894 into lp:ubuntu/maverick-proposed/gwibber

Proposed by Omer Akram on 2010-11-15
Status: Merged
Merged at revision: 64
Proposed branch: lp:~om26er/ubuntu/maverick/gwibber/gwibber-fix-674894
Merge into: lp:ubuntu/maverick-proposed/gwibber
Diff against target: 31 lines (+19/-0)
2 files modified
debian/changelog (+7/-0)
debian/patches/do_not_prepend_is.patch (+12/-0)
To merge this branch: bzr merge lp:~om26er/ubuntu/maverick/gwibber/gwibber-fix-674894
Reviewer Review Type Date Requested Status
Ken VanDine 2010-11-18 Approve on 2010-11-24
Michael Vogt 2010-11-15 Needs Information on 2010-11-22
Review via email: mp+40899@code.launchpad.net
To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks! This looks fine and appropriate for maverick-proposed. In the bugreport there is a link to the change in the upstream bzr as http://bazaar.launchpad.net/~gwibber-committers/gwibber/trunk/revision/928 - is there maybe a typo in this url, it appears to be not linking to the specific fix.

review: Needs Information
Ken VanDine (ken-vandine) wrote :

Looks good, uploaded to maverick-proposed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-10 23:14:44 +0000
3+++ debian/changelog 2010-11-15 19:26:50 +0000
4@@ -1,3 +1,10 @@
5+gwibber (2.32.2-0ubuntu1.1) maverick-proposed; urgency=low
6+
7+ * debian/patches/do_not_prepend_is.patch
8+ - do not prepend 'is ' on facebook status updates (LP: #674894)
9+
10+ -- Omer Akram <om26er@ubuntu.com> Tue, 16 Nov 2010 00:14:22 +0500
11+
12 gwibber (2.32.2-0ubuntu1) maverick-proposed; urgency=low
13
14 * Drop the responses operation from facebook, it abuses the
15
16=== added file 'debian/patches/do_not_prepend_is.patch'
17--- debian/patches/do_not_prepend_is.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/do_not_prepend_is.patch 2010-11-15 19:26:50 +0000
19@@ -0,0 +1,12 @@
20+diff -ruN a//gwibber/microblog/facebook.py b//gwibber/microblog/facebook.py
21+--- a//gwibber/microblog/facebook.py 2010-11-10 10:46:00.000000000 +0500
22++++ b//gwibber/microblog/facebook.py 2010-11-15 22:43:27.716806303 +0500
23+@@ -371,7 +371,7 @@
24+ return []
25+
26+ def send(self, message):
27+- result = self._get("users.setStatus", status=message, status_includes_verb=False)
28++ result = self._get("users.setStatus", status=message, status_includes_verb=True)
29+ if not result:
30+ log.logger.error("<facebook:send> failed")
31+ return

Subscribers

People subscribed via source and target branches

to all changes: