Merge lp:~om26er/ubuntu/lucid/libimobiledevice/fix-iOS5-support into lp:ubuntu/lucid-proposed/libimobiledevice

Proposed by Omer Akram
Status: Needs review
Proposed branch: lp:~om26er/ubuntu/lucid/libimobiledevice/fix-iOS5-support
Merge into: lp:ubuntu/lucid-proposed/libimobiledevice
Diff against target: 47 lines (+27/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/91_fix_iOS5.patch (+19/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~om26er/ubuntu/lucid/libimobiledevice/fix-iOS5-support
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Disapprove
Review via email: mp+64293@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, the current SRU candidate needs to be verified and moved to updates before a new upload though

Revision history for this message
Luke Yelavich (themuso) wrote :

As per the other branches, we need a fix for IOS 5 beta 2.

review: Disapprove

Unmerged revisions

5. By Omer Akram

* debian/patches/91_fix_iOS5.patch:
  - Fix support for iOS5. (LP: #795475)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-06 12:31:24 +0000
3+++ debian/changelog 2011-06-11 11:01:23 +0000
4@@ -1,3 +1,10 @@
5+libimobiledevice (0.9.7-1ubuntu1.2) lucid-proposed; urgency=low
6+
7+ * debian/patches/91_fix_iOS5.patch:
8+ - Fix support for iOS5. (LP: #795475)
9+
10+ -- Omer Akram <om26er@ubuntu.com> Sat, 11 Jun 2011 15:54:36 +0500
11+
12 libimobiledevice (0.9.7-1ubuntu1.1) lucid-proposed; urgency=low
13
14 * Add compatibility for iOS 4.2 and 4.3. This doesn't add new device
15
16=== added file 'debian/patches/91_fix_iOS5.patch'
17--- debian/patches/91_fix_iOS5.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/91_fix_iOS5.patch 2011-06-11 11:01:23 +0000
19@@ -0,0 +1,19 @@
20+From: Omer Akram <om26er@ubuntu.com>
21+Author: Nikias Bassen
22+Subject: Lockdown: fix support for iOS 5.
23+Origin: http://cgit.sukimashita.com/libimobiledevice.git/commit/?id=f0487376671ffd6ac3fc121657f1fbd0acea3cb0
24+Bug-Ubuntu: https://launchpad.net/bugs/795475
25+
26+--- a/src/lockdown.c
27++++ b/src/lockdown.c
28+@@ -86,7 +86,9 @@ static int lockdown_check_result(plist_t dict, const char *query_match)
29+
30+ plist_t result_node = plist_dict_get_item(dict, "Result");
31+ if (!result_node) {
32+- return ret;
33++ /* iOS 5: the 'Result' key is not present anymore.
34++ Just assume success here */
35++ return RESULT_SUCCESS;
36+ }
37+
38+ plist_type result_type = plist_get_node_type(result_node);
39
40=== modified file 'debian/patches/series'
41--- debian/patches/series 2011-06-06 12:31:24 +0000
42+++ debian/patches/series 2011-06-11 11:01:23 +0000
43@@ -3,3 +3,4 @@
44 03-fix-python-import.patch
45 04-ios-42-compat.patch
46 05-ios-43-compat.patch
47+91_fix_iOS5.patch

Subscribers

People subscribed via source and target branches

to all changes: