Merge lp:~om26er/ubuntu-system-settings/upgrade_testing_prerequisite into lp:ubuntu-system-settings

[Omer Akram]

prerequisite for upgrade testing, to land in system-image source.

prerequisite for upgrade testing, to land in system-image source.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:677
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/777/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-trusty-touch/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4605
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-amd64-ci/293
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-armhf-ci/281
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-i386-ci/280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4199
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4199/artifact/work/output/*zip*/output.zip
    None: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5738/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3964
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4729
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4729/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/777/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:678
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/786/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-trusty-touch/139
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4691
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-amd64-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-armhf-ci/290
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-i386-ci/289
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/135
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4274
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4274/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5838
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4048
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4818
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4818/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/786/rebuild

review: Needs Fixing (continuous-integration)

[Omer Akram (om26er)]

Somehow need to figure out how to fake the download manager to be able to write tests for these helpers so that we are sure they don't regress

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:679
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/789/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-trusty-touch/148
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4705
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-amd64-ci/305
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-armhf-ci/293
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-i386-ci/292
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4288
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4288/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5853
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4061
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4832
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4832/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/789/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

Thanks for the work, seems like similar work was started before on https://code.launchpad.net/~chris.gagnon/ubuntu-system-settings/barebones-autopilot-emulator-for-updates-page/+merge/210036 ... are you guys coordinating there? How are the changes differents?

> Somehow need to figure out how to fake the download manager to be able to write tests for these helpers so that we are sure they don't regress

Do you plan to do that? Do you consider your changes useful even if that doesn't happen, or should those works being synchronized?

review: Needs Information

[Omer Akram (om26er)]

> Thanks for the work, seems like similar work was started before on
> https://code.launchpad.net/~chris.gagnon/ubuntu-system-settings/barebones-
> autopilot-emulator-for-updates-page/+merge/210036 ... are you guys
> coordinating there? How are the changes differents?
>

Hi! thanks for your reply and sorry for the delay. Chris's branch is at halt now and my branch is doing a bit different things, so this doesn't need any co-ordination.
>
> > Somehow need to figure out how to fake the download manager to be able to
> write tests for these helpers so that we are sure they don't regress
>
> Do you plan to do that? Do you consider your changes useful even if that
> doesn't happen, or should those works being synchronized?

Yes, at this moment we cannot test these helpers due to missing features like a dummy mode for the upgrader, so you can merge this in now and we'll try to figure out a solution for that sometime in future.

[Sebastien Bacher (seb128)]

Should that be marked "work in progress"? The CI seems still unhappy there...

Note that https://code.launchpad.net/~elopio/ubuntu-system-settings/refactor_about_tests/+merge/226468 is about the land and that your changes are going to need to be rebased, since there is a conflict when applying those on top of trunk

review: Needs Fixing

Unmerged revisions

679. By Omer Akram on 2014-04-09

add pointer parameter to the class

678. By Omer Akram on 2014-04-09

fix things a bit

677. By Omer Akram on 2014-04-08

explain

676. By Omer Akram on 2014-04-08

add helpers for upgrade testing.

675. By Omer Akram on 2014-04-08

add objectName for a few objects, also add new property updatesDownloaded for upgrade testing.

=== modified file 'plugins/system-update/PageComponent.qml'
--- plugins/system-update/PageComponent.qml	2014-03-17 02:08:47 +0000
+++ plugins/system-update/PageComponent.qml	2014-04-09 18:08:02 +0000
@@ -35,6 +35,7 @@
     title: i18n.tr("Updates")
 
     property bool installAll: false
+    property bool updatesDownloaded: false
     property int updatesAvailable: 0
 
     DeviceInfo {
@@ -45,11 +46,13 @@
          id: dialogInstallComponent
          Dialog {
              id: dialogueInstall
+             objectName: "dialogInstall"
              title: i18n.tr("Update System")
              text: i18n.tr("The phone needs to restart to install the system update.")
 
              Button {
                  text: i18n.tr("Install & Restart")
+                 objectName: "btnInstallUpdate"
                  color: UbuntuColors.orange
                  onClicked: {
                      installingImageUpdate.visible = true;
@@ -157,6 +160,7 @@
 
         onSystemUpdateDownloaded: {
             root.updatesAvailable -= 1;
+            root.updatesDownloaded = true;
             PopupUtils.open(dialogInstallComponent);
         }
 

=== added file 'tests/autopilot/ubuntu_system_settings/emulators.py'
--- tests/autopilot/ubuntu_system_settings/emulators.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/ubuntu_system_settings/emulators.py	2014-04-09 18:08:02 +0000
@@ -0,0 +1,98 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Copyright (C) 2014 Canonical Ltd.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation; version 3.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+"""Emulators for updates page used by upgrade tests."""
+
+import time
+import logging
+
+logger = logging.getLogger(__name__)
+
+
+class UpdatesPage(object):
+
+    def __init__(self, app, pointer):
+        self.app = app
+        self.pointer = pointer
+
+    def _get_updates_view(self):
+        return self.app.select_single(
+            'PageComponent', objectName='systemUpdatesPage'
+        )
+
+    def _get_install_dialog(self):
+        return self.app.wait_select_single(
+            'Dialog', objectName='dialogInstall'
+        )
+
+    def _wait_for_dialog(self):
+        dialog = self._get_install_dialog()
+
+        dialog.opacity.wait_for(1.0)
+
+    def get_installing_update_screen(self):
+        return self.app.wait_select_single(
+            'QQuickRectangle', objectName='installingImageUpdate'
+        )
+
+    def wait_for_updates_to_download(self, timeout=40):
+        """Wait for system updates to download
+
+        :returns: None
+        :raises: ValueError
+        """
+        while timeout > 0:
+            download_state = self._get_updates_view().updatesDownloaded
+            if download_state:
+                return
+
+            timeout = timeout - 1
+            time.sleep(5)
+        else:
+            raise ValueError(
+                "Download didn't complete in given time, check your "
+                "internet and try again."
+            )
+
+    def wait_for_state(self, state, timeout=60):
+        """Wait for expected state
+
+        :returns: state
+        :raises: SystemSettingsEmulatorException
+        """
+        for wait in range(timeout):
+            status = self._get_updates_view().state
+            logger.info(
+                'State: {} waiting for {}'.format(status, state)
+            )
+            if state == status:
+                return state
+            time.sleep(1)
+
+        raise ValueError(
+            'Error state {} not found before timeout'.format(state)
+        )
+
+    def click_install_and_restart_button(self):
+        """Wait for the install dialog to appear before clicking
+        on its button.
+        """
+        self._wait_for_dialog()
+        button = self.app.select_single(
+            'Button', objectName='btnInstallUpdate'
+        )
+
+        self.pointer.click_object(button)