Merge lp:~om26er/notes-app/skip into lp:notes-app

[Omer Akram]

Skip problematic tests on nexus 4.

Skip problematic tests on nexus 4. There is still on module test_images that cannot be skipped because the way those tests are written makes it really hard to disable them, python does not like that.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:186
http://jenkins.qa.ubuntu.com/job/notes-app-ci/149/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4092
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1719
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/47
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/47/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/399
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4202
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4202/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1721
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1721/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1438
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1450

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notes-app-ci/149/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

This shouldn’t be needed, let’s fix the app itself.

review: Disapprove

[Olivier Tilloy (osomon)]

On top of this, I’ve observed the failed CI runs of a few MRs for this specific problem, and it seems to affect all tests randomly, not just the tests in the test_parts module. So we’d need to skip every single test for this "solution" to be effective, which would render the autopilot tests pointless. We need to find a real fix.

Unmerged revisions

186. By Omer Akram on 2013-09-27

skip problematic tests on nexus 4, spent more than 6hours on them. Couldn't fix. I reported a bug for the notes-app which I think is also related.

=== modified file 'tests/autopilot/notes_app/tests/test_parts.py'
--- tests/autopilot/notes_app/tests/test_parts.py	2013-07-29 20:53:21 +0000
+++ tests/autopilot/notes_app/tests/test_parts.py	2013-09-27 03:45:52 +0000
@@ -9,15 +9,17 @@
 
 from __future__ import absolute_import
 
-from testtools.matchers import Equals
 from autopilot.matchers import Eventually
 from autopilot.platform import model
+from testtools import skipIf
+from testtools.matchers import Equals
 
 from notes_app.tests import NotesTestCaseBaseWithHTTPServer, DatabaseMixin
 
 import sqlite3
 
 
+@skipIf(model() == 'Nexus 4', "unstable tests on mako due to a race")
 class TestFocus(NotesTestCaseBaseWithHTTPServer, DatabaseMixin):
     """Tests focusing notes"""