Merge lp:~om26er/notes-app/skip into lp:notes-app

Proposed by Omer Akram on 2013-09-27
Status: Rejected
Rejected by: Olivier Tilloy on 2013-10-07
Proposed branch: lp:~om26er/notes-app/skip
Merge into: lp:notes-app
Diff against target: 21 lines (+3/-1)
1 file modified
tests/autopilot/notes_app/tests/test_parts.py (+3/-1)
To merge this branch: bzr merge lp:~om26er/notes-app/skip
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove on 2013-09-27
PS Jenkins bot continuous-integration Approve on 2013-09-27
Bill Filler 2013-09-27 Pending
Review via email: mp+187967@code.launchpad.net

Commit message

Skip problematic tests on nexus 4.

Description of the change

Skip problematic tests on nexus 4. There is still on module test_images that cannot be skipped because the way those tests are written makes it really hard to disable them, python does not like that.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Olivier Tilloy (osomon) wrote :

This shouldn’t be needed, let’s fix the app itself.

review: Disapprove
Olivier Tilloy (osomon) wrote :

On top of this, I’ve observed the failed CI runs of a few MRs for this specific problem, and it seems to affect all tests randomly, not just the tests in the test_parts module. So we’d need to skip every single test for this "solution" to be effective, which would render the autopilot tests pointless. We need to find a real fix.

Unmerged revisions

186. By Omer Akram on 2013-09-27

skip problematic tests on nexus 4, spent more than 6hours on them. Couldn't fix. I reported a bug for the notes-app which I think is also related.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/notes_app/tests/test_parts.py'
2--- tests/autopilot/notes_app/tests/test_parts.py 2013-07-29 20:53:21 +0000
3+++ tests/autopilot/notes_app/tests/test_parts.py 2013-09-27 03:45:52 +0000
4@@ -9,15 +9,17 @@
5
6 from __future__ import absolute_import
7
8-from testtools.matchers import Equals
9 from autopilot.matchers import Eventually
10 from autopilot.platform import model
11+from testtools import skipIf
12+from testtools.matchers import Equals
13
14 from notes_app.tests import NotesTestCaseBaseWithHTTPServer, DatabaseMixin
15
16 import sqlite3
17
18
19+@skipIf(model() == 'Nexus 4', "unstable tests on mako due to a race")
20 class TestFocus(NotesTestCaseBaseWithHTTPServer, DatabaseMixin):
21 """Tests focusing notes"""
22

Subscribers

People subscribed via source and target branches