mediaplayer-app

Merge lp:~om26er/mediaplayer-app/fix_mediaselector_test into lp:mediaplayer-app

  1. fix_mediaselector_test
  2. Merge into trunk
Proposed by Omer Akram
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 131
Merged at revision: 131
Proposed branch: lp:~om26er/mediaplayer-app/fix_mediaselector_test
Merge into: lp:mediaplayer-app
Diff against target: 17 lines (+3/-2)
1 file modified
tests/autopilot/mediaplayer_app/tests/test_player_with_video.py (+3/-2)
To merge this branch: bzr merge lp:~om26er/mediaplayer-app/fix_mediaselector_test
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+183918@code.launchpad.net

Commit message

Wait for the scene selector to be visible fully before clicking anything, that may ignore the click

Description of the change

Fixes a failing mediaplayer test

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:131
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/94/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2994
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/558
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-ci/30/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-i386-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3000
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3000/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2546
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/560
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/560/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/499
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/511

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mediaplayer-app-ci/94/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/mediaplayer_app/tests/test_player_with_video.py'
2--- tests/autopilot/mediaplayer_app/tests/test_player_with_video.py 2013-07-02 20:03:26 +0000
3+++ tests/autopilot/mediaplayer_app/tests/test_player_with_video.py 2013-09-04 16:10:02 +0000
4@@ -132,10 +132,11 @@
5
6 time_line = self.main_window.get_object("Slider", "TimeLine.Slider")
7 time_label = self.main_window.get_object("Label", "TimeLine.TimeLabel")
8+ scene_selector = self.main_window.get_object("SceneSelector", "Controls.SceneSelector")
9
10 """ Seek to the midle of the movie """
11- self.pointing_device.move_to_object(time_line)
12- self.pointing_device.click()
13+ self.pointing_device.click_object(time_line)
14+ self.assertThat(scene_selector.opacity, Eventually(Equals(1)))
15
16 """ Time label must show the current video time (diff from zero or empty) """
17 self.assertNotEqual(time_label.text, "00:00:00")

Subscribers

People subscribed via source and target branches