Merge ~om26er/dekko:master into dekko:master

Proposed by Dan Chapman 
Status: Merged
Merged at revision: ac39b891199d24c9a22c3d938355e51ea9066c5d
Proposed branch: ~om26er/dekko:master
Merge into: dekko:master
Diff against target: 32 lines (+14/-0)
1 file modified
qml/Components/EncryptionSelector.qml (+14/-0)
Reviewer Review Type Date Requested Status
Dan Chapman  (community) Approve
Omer Akram (community) Approve
Review via email: mp+291660@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

Looks good to me

review: Approve
Revision history for this message
Dan Chapman  (dpniel) wrote :

Looks good to me as well. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/qml/Components/EncryptionSelector.qml b/qml/Components/EncryptionSelector.qml
2index ae5fb3e..2bcec2f 100644
3--- a/qml/Components/EncryptionSelector.qml
4+++ b/qml/Components/EncryptionSelector.qml
5@@ -59,6 +59,7 @@ Selector {
6 model: encryptionMethodModel
7 delegate: CheckboxWithLabel {
8 id: delegate
9+ objectName: "encryption" + getEncryptionTypeFromModelIndex(model.index)
10 text: description
11 property bool isSelected: selectedIndex === model.index
12 checked: selectedIndex === model.index
13@@ -70,6 +71,19 @@ Selector {
14 delegate.checked = delegate.isSelected
15 }
16 }
17+
18+ function getEncryptionTypeFromModelIndex(modelIndex) {
19+ switch (modelIndex) {
20+ case 0:
21+ return "None"
22+ case 1:
23+ return "STARTTLS"
24+ case 2:
25+ return "SSL"
26+ default:
27+ return ''
28+ }
29+ }
30 }
31 }
32 }

Subscribers

People subscribed via source and target branches