Merge lp:~om26er/address-book-app/test_collapse into lp:address-book-app

[Omer Akram]

autopilot: add test to make sure contact list expansion and collision is intact.

autopilot: add test to make sure contact list expansion and collision is intact.

[lp:~om26er/address-book-app/test_collapse]

167. By Omer Akram on 2014-03-18

merge with prereq branch

168. By Omer Akram on 2014-03-18

add docstring and a connect to make it clear why we are using sleep

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/459/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-amd64-ci/169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/169
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/169/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-i386-ci/169
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4019
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3604/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3509
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4060
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4060/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3606
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3606/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5935/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4909

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/459/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:168
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/461/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-amd64-ci/171
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/171
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-armhf-ci/171/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-trusty-i386-ci/171
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4023
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3608/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3513
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4064
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4064/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3610
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3610/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5938/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4914

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/461/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

I left some comments inline.
This makes me wonder if it should be a QML test for the list component. It would be ok to make it an autopilot test only if the QML test is too complex.

review: Needs Fixing

Unmerged revisions

168. By Omer Akram on 2014-03-18

add docstring and a connect to make it clear why we are using sleep

167. By Omer Akram on 2014-03-18

merge with prereq branch

166. By Omer Akram on 2014-03-18

bring in Allan's collapse test case and adapt it to altest changes

165. By Omer Akram on 2014-03-18

make dummy backend code reusable by other test cases

164. By Omer Akram on 2014-03-18

remove unused test code, fix things

163. By Omer Akram on 2014-03-18

remove syncevolution dep

162. By Omer Akram on 2014-03-17

fix pep8 and pyflakes warnings for test_favorite, did not touch other modules

161. By Omer Akram on 2014-03-17

remove unused test code

160. By Omer Akram on 2014-03-17

don't use memory backend for favorite tests, use the new dummy backend from the service

159. By Omer Akram on 2014-03-13

merge new-fav-list branch

=== modified file 'tests/autopilot/address_book_app/emulators/contact_list_page.py'
--- tests/autopilot/address_book_app/emulators/contact_list_page.py	2014-03-18 12:37:36 +0000
+++ tests/autopilot/address_book_app/emulators/contact_list_page.py	2014-03-18 12:37:36 +0000
@@ -214,3 +214,30 @@
         except StateNotFoundError:
             logger.error("Favorite contact {} not found.".format(name))
             return False
+
+    def get_header_by_letter(self, header_letter):
+        """Get the index header by its letter string (text), e.g. 'B'
+
+        :param header_letter: Index letter text, e.g. 'B'
+        :raises StateNotFoundError: if header letter not found
+        """
+        return self.wait_select_single('Header',
+                                       text=header_letter,
+                                       visible=True)
+        
+    def click_header_by_letter(self, header_letter):
+        """Click the index header by its letter string (text), e.g. 'B'
+
+        :param header_letter: Index letter text, e.g. 'B'
+        :raises StateNotFoundError: if header letter not found
+        """
+        header = self.get_header_by_letter(header_letter)
+        self.pointing_device.click_object(header)
+
+    def is_expanded(self):
+        """Is the ContactListView expanded?
+
+        :raises StateNotFoundError: if the ContactListView is not found
+        """
+        contact_list_view = self.wait_select_single('ContactListView')
+        return contact_list_view.expanded == True

=== added file 'tests/autopilot/address_book_app/tests/test_collapse.py'
--- tests/autopilot/address_book_app/tests/test_collapse.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/address_book_app/tests/test_collapse.py	2014-03-18 12:37:36 +0000
@@ -0,0 +1,48 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright 2014 Canonical
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+
+"""Tests of collapsing/expanding address-book-app contacts list"""
+
+from __future__ import absolute_import
+
+from autopilot.introspection.dbus import StateNotFoundError
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals
+
+from address_book_app.tests import DummyServiceBackendSetup
+from address_book_app.emulators.contact_list_page import ContactListPage
+
+import time
+
+
+class TestCollapse(DummyServiceBackendSetup):
+    """Test for collapsing and expanding the contacts list"""
+
+    def setUp(self):
+        super(TestCollapse, self).setUp()
+
+    def test_contract_and_expand_list(self):
+        """Ensure contacts list can be expanded and collapsed."""
+        contact_list_page = self.main_window.get_contact_list_page()
+        contact_list_page.get_contact_by_name('Zack Constantine')
+        contact_list_page.click_header_by_letter('T')
+        # bit of a wait here
+        self.assertThat(lambda: contact_list_page.is_expanded(),
+                        Eventually(Equals(False)))
+        # just also verify that contacts are visible (one is enough)
+        self.assertRaises(
+            StateNotFoundError,
+            lambda : contact_list_page.get_contact_by_name('Zack Constantine'))
+        contact_list_page.click_header_by_letter('Z')
+        self.assertThat(lambda: contact_list_page.is_expanded(),
+                        Eventually(Equals(True)))
+
+        # Using a 1 second sleep here because currently the .expanded
+        # property is not reliable
+        time.sleep(1)
+        contact_list_page.get_contact_by_name('teste teste2')
+        contact_list_page.get_contact_by_name('Zack Constantine')

=== modified file 'tests/data/vcard.vcf'
--- tests/data/vcard.vcf	2013-12-12 15:55:57 +0000
+++ tests/data/vcard.vcf	2014-03-18 12:37:36 +0000
@@ -28,3 +28,13 @@
 TEL:111111
 CATEGORIES:T
 END:VCARD
+BEGIN:VCARD
+VERSION:3.0
+UID:0d753ce1005dde92f69e4ddb62222240639113a3
+X-QTPROJECT-EXTENDED-DETAIL:CLIENTPIDMAP;[\n    "1"\n]\n
+N:Constantine;Zack;;;
+FN:Zack Constantine
+X-QTPROJECT-FAVORITE:false;0
+TEL:98878
+CATEGORIES:T
+END:VCARD