Merge lp:~olivier-martin/lightdm/fixed-yelp into lp:lightdm

[Olivier Martin]

Makefile: Fixed @YELP_HELP_RULES@: *** missing separator

'yelp-tools' are required to build lighthm.
This change checks if yelp-tools are installed prior to configure & build lighthm as recommended on this page:
https://wiki.gnome.org/Initiatives/GnomeGoals/NewDocumentationInfrastructure

[Robert Ancell (robert-ancell)]

"please intall the yelp-tool package"
should read
"please install the yelp-tools package"

[Robert Ancell (robert-ancell)]

Otherwise looks good, thanks!

[lp:~olivier-martin/lightdm/fixed-yelp]

2003. By Olivier Martin on 2014-06-26

Makefile: Fixed @YELP_HELP_RULES@: *** missing separator

'yelp-tools' are required to build lighthm.
This change checks if yelp-tools are installed prior to
configure & build lighthm as recommended on this page:
https://wiki.gnome.org/Initiatives/GnomeGoals/NewDocumentationInfrastructure

[Olivier Martin (olivier-martin)]

Thanks for the feedback. I have just pushed a new version that fixes this
typo.

On 26 June 2014 23:26, Robert Ancell <email address hidden> wrote:

> Otherwise looks good, thanks!
> --
> https://code.launchpad.net/~olivier-martin/lightdm/fixed-yelp/+merge/224729
> You are the owner of lp:~olivier-martin/lightdm/fixed-yelp.
>

[Robert Ancell (robert-ancell)]

Still says "intall".

I think you did a push --overwrite? You can just push changes without overwriting.

review: Needs Fixing

[lp:~olivier-martin/lightdm/fixed-yelp]

2004. By Olivier Martin on 2014-06-27

autogen.sh: Fixed typo

[Olivier Martin (olivier-martin)]

Anything missing in this patch?

review: Needs Resubmitting

[Robert Ancell (robert-ancell)]

Looks good now, thanks!

review: Approve

=== modified file 'autogen.sh'
--- autogen.sh	2013-09-11 17:56:09 +0000
+++ autogen.sh	2014-06-27 08:42:53 +0000
@@ -8,6 +8,14 @@
 autoconf
 autoheader
 automake --add-missing --copy --foreign
+
+YELP=`which yelp-build`
+if test -z $YELP; then
+  echo "*** The tools to build the documentation are not found,"
+  echo "    please install the yelp-tools package ***"
+  exit 1
+fi
+
 if [ -z "$NOCONFIGURE" ]; then
     ./configure $@
 fi