LightDM GTK Greeter

Merge lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-no-password-guest into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

  1. lightdm-gtk-greeter-no-password-guest
  2. Merge into trunk
Proposed by Olivier Martin
Status: Merged
Merged at revision: 292
Proposed branch: lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-no-password-guest
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 23 lines (+6/-0)
1 file modified
src/lightdm-gtk-greeter.c (+6/-0)
To merge this branch: bzr merge lp:~olivier-martin/lightdm-gtk-greeter/lightdm-gtk-greeter-no-password-guest
Reviewer Review Type Date Requested Status
Andrew P. Approve
Review via email: mp+224796@code.launchpad.net

Description of the change

Hide password for guest session

To post a comment you must log in.
Revision history for this message
Andrew P. (kalgasnik) wrote :

Looks sane, but there is no focus handling changes in your patch.
I'll edit and merge it in a few days. The same for "password_entry-optional" branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/lightdm-gtk-greeter.c'
2--- src/lightdm-gtk-greeter.c 2014-06-09 15:49:08 +0000
3+++ src/lightdm-gtk-greeter.c 2014-06-27 11:35:10 +0000
4@@ -1349,6 +1349,7 @@
5 {
6 gchar *user_tooltip;
7 LightDMUser *user;
8+ gboolean password_visible = TRUE;
9
10 if (g_strcmp0 (username, "*other") == 0)
11 {
12@@ -1367,6 +1368,11 @@
13 if (g_strcmp0 (username, "*guest") == 0)
14 {
15 user_tooltip = g_strdup(_("Guest Session"));
16+ password_visible = FALSE;
17+ }
18+
19+ if (gtk_widget_get_visible (GTK_WIDGET (password_entry)) != password_visible) {
20+ gtk_widget_set_visible (GTK_WIDGET (password_entry), password_visible);
21 }
22
23 set_login_button_label (greeter, username);

Subscribers

People subscribed via source and target branches