Gwibber

Merge lp:~olivier-faurax/gwibber/oauth-with-webkit-disabled-plugins into lp:gwibber

  1. oauth-with-webkit-disabled-plugins
  2. Merge into trunk
Proposed by Olivier FAURAX
Status: Merged
Merged at revision: 855
Proposed branch: lp:~olivier-faurax/gwibber/oauth-with-webkit-disabled-plugins
Merge into: lp:gwibber
Diff against target: 11 lines (+1/-0)
1 file modified
gwibber/lib/gtk/twitter.py (+1/-0)
To merge this branch: bzr merge lp:~olivier-faurax/gwibber/oauth-with-webkit-disabled-plugins
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+35420@code.launchpad.net

Description of the change

This change disables the use of plugins in the webkit instance that is used to get the OAuth token for twitter account registration in gwibber.

We don't need to load plugins to access OAuth form on twitter website.

I discovered the problem with one of my plugin taking 100% of CPU after OAuth page load, and preventing me to register my twitter account in gwibber.

I proposed the merge in lp:gwibber, but lp:2.30 is also concerned.

To post a comment you must log in.
Revision history for this message
Vadim Rutkovsky (roignac) wrote :

I have actually tried this, but if it works, this should be added for other OAuth services - for now it is Google Buzz and Facebook

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Error in my previous comment - "I have NOT actually tried this"

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/lib/gtk/twitter.py'
2--- gwibber/lib/gtk/twitter.py 2010-08-31 15:30:06 +0000
3+++ gwibber/lib/gtk/twitter.py 2010-09-14 15:17:58 +0000
4@@ -56,6 +56,7 @@
5 self.winsize = self.window.get_size()
6
7 web = webkit.WebView()
8+ web.get_settings().set_property("enable-plugins", False)
9 web.load_html_string(_("<p>Please wait...</p>"), "file:///")
10
11 self.consumer = oauth.OAuthConsumer(*resources.get_twitter_keys())