Merge lp:~oldmanuk/bzr-autoreview/support-dot-plugins-install into lp:bzr-autoreview

[Dominic Evans]

[Dominic Evans (oldmanuk)]

Small patch to allow bzr-autoreview to be installed via:

$ cd ~/.bazaar/plugins
$ bzr branch lp:bzr-autoreview autoreview

Rather than having to install it globally using distutils.

[Paul Hummer (rockstar)]

Dominic-

  Thanks for the branch. I hadn't even released 24 hours previous, and I've
already gotten your contribution. Thanks for you work!

  I've been running this plugin from ~/.bazaar/plugins What issues have you
been having? I don't think this specific change is really the direction we
want to go in.

  To install, I usually do:

  cd ~/.bazaar/plugins; bzr branch lp:bzr-autoreview autoreview

  If you're having problems after doing that, then I think we need to
investigate it more.

Cheers,
Paul

review: Needs Fixing

[Dominic Evans (oldmanuk)]

Hmm. When I tested it on my Jaunty laptop, doing the exactly same steps as you mention, it failed to find autoreview via bzrlib so I had to make these changes.

However, repeating the steps on my Jaunty server, all worked out of the box this way.

I'll cancel this merge :)

Unmerged revisions

22. By Dominic Evans on 2009-03-09

Reference autoreview locally rather than via bzrlib.plugins. Seemed to be the only way to get it to work in ~/.bazaar/plugins/autoreview

=== modified file '__init__.py'
--- __init__.py	2009-02-24 04:00:46 +0000
+++ __init__.py	2009-03-09 12:16:55 +0000
@@ -1,5 +1,5 @@
 # Copyright (c) 2009 Paul Hummer <[e-mail]>
-from bzrlib.plugins.autoreview.commands import *
+from commands import *
 
 commands.register_command(cmd_autoreview, 'autoreview')
 

=== modified file 'commands.py'
--- commands.py	2009-03-09 06:37:56 +0000
+++ commands.py	2009-03-09 12:16:55 +0000
@@ -10,7 +10,7 @@
 from bzrlib.diff import _get_trees_to_diff, show_diff_trees
 from bzrlib.email_message import EmailMessage
 from bzrlib.msgeditor import edit_commit_message
-from bzrlib.plugins.autoreview.utils import get_launchpad_api_object
+from utils import get_launchpad_api_object
 from bzrlib.workingtree import WorkingTree
 from bzrlib.smtp_connection import SMTPConnection
 from launchpadlib.launchpad import EDGE_SERVICE_ROOT