Merge lp:~okay19/ubuntu/wily/wpa/fix-bug-1405452 into lp:ubuntu/wily/wpa

Proposed by Dillon Brock on 2016-01-02
Status: Rejected
Rejected by: Brian Murray on 2016-01-27
Proposed branch: lp:~okay19/ubuntu/wily/wpa/fix-bug-1405452
Merge into: lp:ubuntu/wily/wpa
Diff against target: 45 lines (+25/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/series (+1/-0)
debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch (+16/-0)
To merge this branch: bzr merge lp:~okay19/ubuntu/wily/wpa/fix-bug-1405452
Reviewer Review Type Date Requested Status
Brian Murray 2016-01-02 Disapprove on 2016-01-27
Review via email: mp+281468@code.launchpad.net
To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Thank you for your work, that bug is also in Debian where the package is initially coming from, could you send the patch to them as well?

Dillon Brock (okay19) wrote :

I have sent the patch upstream and linked the Debian report to the original issue.

Brian Murray (brian-murray) wrote :

Thanks for working on this, while the patch looks good it isn't quite worthy of the work required for a Stable Release Update. Subsequently, I'm going to reject the merge for Wily.

review: Disapprove

Unmerged revisions

23. By Dillon Brock on 2016-01-02

debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch:
change "much improvement" to "much improved" in wpa_supplicant doc
(LP: #1405452)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-10-07 10:21:39 +0000
3+++ debian/changelog 2016-01-02 14:57:41 +0000
4@@ -1,3 +1,11 @@
5+wpa (2.4-0ubuntu4~okay) UNRELEASED; urgency=medium
6+
7+ * debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch:
8+ change "much improvement" to "much improved" in wpa_supplicant doc
9+ (LP: #1405452)
10+
11+ -- Dillon Brock <dab9861@gmail.com> Sat, 02 Jan 2016 09:09:58 -0500
12+
13 wpa (2.4-0ubuntu3) wily; urgency=medium
14
15 * debian/patches/dbus-fix-operations-for-p2p-mgmt.patch: fix operations
16
17=== modified file 'debian/patches/series'
18--- debian/patches/series 2015-10-07 10:21:39 +0000
19+++ debian/patches/series 2016-01-02 14:57:41 +0000
20@@ -13,3 +13,4 @@
21 CVE-2015-4143-4146.patch
22 android_hal_fw_path_change.patch
23 dbus-fix-operations-for-p2p-mgmt.patch
24+wpasupplicant_fix-improvement-typo-in-doc.patch
25
26=== added file 'debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch'
27--- debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch 1970-01-01 00:00:00 +0000
28+++ debian/patches/wpasupplicant_fix-improvement-typo-in-doc.patch 2016-01-02 14:57:41 +0000
29@@ -0,0 +1,16 @@
30+## Description: fix typo in wpa_supplicant doc
31+## Origin/Author: Dillon Brock <dab9861@gmail.com>
32+## Bug: LP #1405452
33+Index: wpa.dev/wpa_supplicant/doc/docbook/wpa_supplicant.sgml
34+===================================================================
35+--- wpa.dev.orig/wpa_supplicant/doc/docbook/wpa_supplicant.sgml 2016-01-02 09:07:47.717483000 -0500
36++++ wpa.dev/wpa_supplicant/doc/docbook/wpa_supplicant.sgml 2016-01-02 09:09:50.954344730 -0500
37+@@ -42,7 +42,7 @@
38+ can be used to improve the network security, but even that has inherited
39+ security issues due to the use of WEP for encryption. Wi-Fi Protected
40+ Access and IEEE 802.11i amendment to the wireless LAN standard introduce
41+- a much improvement mechanism for securing wireless networks. IEEE 802.11i
42++ a much improved mechanism for securing wireless networks. IEEE 802.11i
43+ enabled networks that are using CCMP (encryption mechanism based on strong
44+ cryptographic algorithm AES) can finally be called secure used for
45+ applications which require efficient protection against unauthorized

Subscribers

People subscribed via source and target branches

to all changes: