Qt

Merge lp:~oif-team/qt/touch-end-fix into lp:~kubuntu-packagers/kubuntu-packaging/qt

Proposed by Chase Douglas
Status: Merged
Merge reported by: Felix Geyer
Merged at revision: not available
Proposed branch: lp:~oif-team/qt/touch-end-fix
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qt
Diff against target: 55 lines (+16/-7)
2 files modified
debian/changelog (+7/-0)
debian/patches/kubuntu_28_xi2.1.patch (+9/-7)
To merge this branch: bzr merge lp:~oif-team/qt/touch-end-fix
Reviewer Review Type Date Requested Status
Felix Geyer Approve
Review via email: mp+63417@code.launchpad.net

Description of the change

Fixes touch end handling. The bug is apparent when trying to use the TouchArea Qml plugin.

To post a comment you must log in.
Revision history for this message
Felix Geyer (debfx) wrote :

Merged, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-05-31 14:09:36 +0000
3+++ debian/changelog 2011-06-03 18:07:18 +0000
4@@ -1,3 +1,10 @@
5+qt4-x11 (4:4.7.3-1ubuntu2) UNRELEASED; urgency=low
6+
7+ * Fix touch end event handling, LP: #785433
8+ - Updated kubuntu_28_xi2.1.patch with the fix
9+
10+ -- Chase Douglas <chase.douglas@ubuntu.com> Fri, 03 Jun 2011 09:42:09 -0400
11+
12 qt4-x11 (4:4.7.3-1ubuntu1) oneiric; urgency=low
13
14 * Merge from Debian unstable, remaining changes:
15
16=== modified file 'debian/patches/kubuntu_28_xi2.1.patch'
17--- debian/patches/kubuntu_28_xi2.1.patch 2011-03-03 18:31:54 +0000
18+++ debian/patches/kubuntu_28_xi2.1.patch 2011-06-03 18:07:18 +0000
19@@ -492,7 +492,7 @@
20 default:
21 break;
22 }
23-@@ -5081,6 +5176,184 @@
24+@@ -5081,6 +5176,186 @@
25 return true;
26 }
27
28@@ -650,7 +650,14 @@
29 + tp->setState(Qt::TouchPointReleased | primary);
30 + if (qAppPriv->appTouchPoints.isEmpty())
31 + send = false;
32-+
33++ }
34++
35++ if (send) {
36++ qAppPriv->activeDeviceType = tdi.directTouch ? QTouchEvent::TouchScreen : QTouchEvent::TouchPad;
37++ QApplicationPrivate::translateRawTouchEvent(0, qAppPriv->activeDeviceType, qAppPriv->appTouchPoints);
38++ }
39++
40++ if (event->evtype == XI_TouchEnd) {
41 + for (int i = 0; i < qAppPriv->appTouchPoints.size(); ++i) {
42 + if (qAppPriv->appTouchPoints[i].id() == trackingId) {
43 + qAppPriv->appTouchPoints.removeAt(i);
44@@ -666,11 +673,6 @@
45 + }
46 + }
47 +
48-+ if (send) {
49-+ qAppPriv->activeDeviceType = tdi.directTouch ? QTouchEvent::TouchScreen : QTouchEvent::TouchPad;
50-+ QApplicationPrivate::translateRawTouchEvent(0, qAppPriv->activeDeviceType, qAppPriv->appTouchPoints);
51-+ }
52-+
53 + return true;
54 +}
55 +#endif

Subscribers

People subscribed via source and target branches