Merge lp:~oif-team/grail/trunk.lp-748282 into lp:grail

Proposed by Henrik Rydberg
Status: Merged
Merged at revision: 141
Proposed branch: lp:~oif-team/grail/trunk.lp-748282
Merge into: lp:grail
Diff against target: 21 lines (+4/-0)
1 file modified
src/gestures-touch.c (+4/-0)
To merge this branch: bzr merge lp:~oif-team/grail/trunk.lp-748282
Reviewer Review Type Date Requested Status
Chase Douglas (community) Approve
Review via email: mp+56224@code.launchpad.net

This proposal supersedes a proposal from 2011-04-04.

Description of the change

Seems to work over here. Tested using grail-gesture with two gesture masks: 0xffffffffffffffff and 0x0000000f00000000

To post a comment you must log in.
Revision history for this message
Henrik Rydberg (rydberg) wrote :

Forgot to merge a fix from last week, so tree got convoluted - resubmitting this branch on top of the fresh trunk.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

This looks correct and improves the handling of touch gestures. There's still a question about whether the glue timeouts are long enough, but this can be addressed in a second merge request if needed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/gestures-touch.c'
2--- src/gestures-touch.c 2011-03-28 20:04:07 +0000
3+++ src/gestures-touch.c 2011-04-04 17:28:34 +0000
4@@ -53,6 +53,8 @@
5 state->gid = gin_gid_begin(ge, type, -PRIO_GESTURE, frame);
6 state->active = 1;
7 }
8+ if (move->time - move->fm[FM_X].original_ms <= move->fm[FM_X].hold_ms)
9+ return 0;
10 state->nprop = gin_add_contact_props(ge->gin, state->prop, frame);
11 gru_event(ge, state->gid, move, state->prop, state->nprop);
12 return 1;
13@@ -88,6 +90,8 @@
14 return 0;
15 }
16 }
17+ if (move->time - move->fm[FM_X].original_ms <= move->fm[FM_X].hold_ms)
18+ return 0;
19 state->nprop = gin_add_contact_props(ge->gin, state->prop, frame);
20 gru_event(ge, state->gid, move, state->prop, state->nprop);
21 return 1;

Subscribers

People subscribed via source and target branches

to all changes: