Code review comment for lp:~oif-team/grail/cooperate-with-xi2.1

Revision history for this message
Stephen M. Webb (bregma) wrote :

The changes look sensible, but the magic timing constants are buried in the code. I think it would be beneficial to future maintainers if they were moved to the top of the source file (as defines or static consts) and comments added to each reiterating what is in the change log.

Other than that stylistic suggestion this is good to go.

review: Approve

« Back to merge proposal