First, thanks Josh for the patch! The major change here is good, there's just a small list of things that need to be cleaned up:
* The comment at the top is great! Please remove the "Edits made by joshfee Aug 7 2011" line. When we merge the branch back to the tree I'll make sure to list you as the author of the commit.
* Please use 4 spaces for indentation so it fits with the rest of the source code.
* There's a multi-line comment that uses "///" at the beginning of each line. I would prefer if it had the same multi-line comment format as your comment at the top. Also, use "//" instead of "///" for single line comments.
* Please put the "int finished = 0" declaration with the other variable declarations at the top of the scope before the comments.
* Use plain printf(...) instead of fprintf(stdout, ...)
* Normally we want people to use the macros for gesture subscription, like GESTURE_TYPE_DRAG_1. However, that would cause an explosion of switch statements in the code if we enforced that here. I am ok with letting this slide.
First, thanks Josh for the patch! The major change here is good, there's just a small list of things that need to be cleaned up:
* The comment at the top is great! Please remove the "Edits made by joshfee Aug 7 2011" line. When we merge the branch back to the tree I'll make sure to list you as the author of the commit.
* Please use 4 spaces for indentation so it fits with the rest of the source code.
* There's a multi-line comment that uses "///" at the beginning of each line. I would prefer if it had the same multi-line comment format as your comment at the top. Also, use "//" instead of "///" for single line comments.
* Please put the "int finished = 0" declaration with the other variable declarations at the top of the scope before the comments.
* Use plain printf(...) instead of fprintf(stdout, ...)
* Normally we want people to use the macros for gesture subscription, like GESTURE_ TYPE_DRAG_ 1. However, that would cause an explosion of switch statements in the code if we enforced that here. I am ok with letting this slide.
Again, great code! Thanks for submitting it!