Merge lp:~oif-team/geis/geis2-move-geisimpl into lp:geis

Proposed by Stephen M. Webb
Status: Merged
Merged at revision: 99
Proposed branch: lp:~oif-team/geis/geis2-move-geisimpl
Merge into: lp:geis
Diff against target: 176 lines (+53/-12)
9 files modified
ChangeLog (+20/-0)
configure.ac (+1/-0)
libutouch-geis-xcb/Makefile.am (+0/-2)
libutouch-geis/Makefile.am (+5/-1)
libutouch-geis/backend/Makefile.am (+23/-0)
testsuite/geis1/Makefile.am (+1/-3)
testsuite/geis2/Makefile.am (+1/-4)
testsuite/geistest/Makefile.am (+1/-1)
testsuite/libutouch-geis/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~oif-team/geis/geis2-move-geisimpl
Reviewer Review Type Date Requested Status
Henrik Rydberg (community) Approve
Review via email: mp+44966@code.launchpad.net

Description of the change

Two minor changes to build infrastructure.

(1) Relocated geisimpl.h header file so "make distcheck" runs cleanly.

(2) Added backend subdirectory to libutouch-geis subproject for upcoming work.

To post a comment you must log in.
Revision history for this message
Henrik Rydberg (rydberg) wrote :

looks fine with me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog'
2--- ChangeLog 2010-12-21 13:59:31 +0000
3+++ ChangeLog 2010-12-31 20:37:54 +0000
4@@ -1,3 +1,23 @@
5+2010-12-29 Stephen M. Webb <stephen.webb@canonical.com>
6+
7+ Added backend subdirectory to libutouch-geis.
8+
9+ * libutouch-geis/backend/Makefile.am: new file
10+ * configure.ac (AC_OUTPUT): added libutouch-geis/backend/Makefile
11+ * libutouch-geis/Makefile.am (SUBDORS): added backend
12+
13+2010-12-29 Stephen M. Webb <stephen.webb@canonical.com>
14+
15+ Moved geis/geisimpl.h into GEIS v2.0 sources.
16+
17+ * libutouch-geis/geis/geisimple.h: renamed from libutouch-geis-xcb/geis
18+ * libutouch-geis-xcb/Makefile.am: changed header search path
19+ * libutouch-geis/Makefile.am: changed header search path
20+ * testsuite/geis1/Makefile.am: changed header search path
21+ * testsuite/geis2/Makefile.am: changed header search path
22+ * testsuite/geistest/Makefile.am: changed header search path
23+ * testsuite/libutouch-geis/Makefile.am: changed header search path
24+
25 2010-12-20 Stephen M. Webb <stephen.webb@canonical.com>
26
27 Added GEIS v2.0 input device implementation.
28
29=== modified file 'configure.ac'
30--- configure.ac 2010-11-24 20:15:13 +0000
31+++ configure.ac 2010-12-31 20:37:54 +0000
32@@ -87,6 +87,7 @@
33 libutouch-geis-xcb/Makefile
34 libutouch-geis-xcb/xcb_gesture.xml
35 libutouch-geis/Makefile
36+ libutouch-geis/backend/Makefile
37 testsuite/Makefile
38 testsuite/libutouch-geis/Makefile
39 testsuite/geis1/Makefile
40
41=== modified file 'libutouch-geis-xcb/Makefile.am'
42--- libutouch-geis-xcb/Makefile.am 2010-11-23 18:06:40 +0000
43+++ libutouch-geis-xcb/Makefile.am 2010-12-31 20:37:54 +0000
44@@ -8,8 +8,6 @@
45 # work around a problem with XCB tools
46 XCB_CFLAGS += -I$(includedir)/xcb -I$(XCBINCLUDEDIR)/xcb
47
48-dist_inc_HEADERS = geis/geisimpl.h
49-
50 noinst_LTLIBRARIES = libutouch-geis.la
51
52 libutouch_geis_la_SOURCES = \
53
54=== modified file 'libutouch-geis/Makefile.am'
55--- libutouch-geis/Makefile.am 2010-12-21 01:47:05 +0000
56+++ libutouch-geis/Makefile.am 2010-12-31 20:37:54 +0000
57@@ -20,8 +20,12 @@
58 #
59 version_script = $(srcdir)/libutouch-geis.ver
60
61+SUBDIRS = backend
62+
63 lib_LTLIBRARIES = libutouch-geis.la
64
65+nobase_include_HEADERS = geis/geisimpl.h
66+
67 libutouch_geis_la_SOURCES = \
68 geis_attr.h geis_attr.c \
69 geis_backend.h geis_backend.c \
70@@ -43,7 +47,7 @@
71 -DGEIS_BUILDING_DSO=1 \
72 -I$(top_srcdir) \
73 -I$(top_srcdir)/include \
74- -I$(top_srcdir)/libutouch-geis-xcb \
75+ -I$(srcdir)/backend \
76 $(GRAIL_CFLAGS)
77
78 libutouch_geis_la_LDFLAGS = \
79
80=== added directory 'libutouch-geis/backend'
81=== added file 'libutouch-geis/backend/Makefile.am'
82--- libutouch-geis/backend/Makefile.am 1970-01-01 00:00:00 +0000
83+++ libutouch-geis/backend/Makefile.am 2010-12-31 20:37:54 +0000
84@@ -0,0 +1,23 @@
85+#
86+# @file libutouch-geis/backends/Makefile.am
87+# @brief automake recipe for the uTouch GEIS v2.0 implementation back ends
88+#
89+# Copyright 2010 Canonical, Ltd.
90+#
91+# This file is part of the utouch-geis library. This library is free software;
92+# you can redistribute it and/or modify it under the terms of the GNU Lesser
93+# General Public License as published by the Free Software Foundation; either
94+# version 3 of the License, or (at your option) any later version.
95+#
96+# This library is distributed in the hope that it will be useful, but WITHOUT
97+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
98+# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
99+# details.
100+#
101+# You should have received a copy of the GNU Lesser General Public License
102+# along with this program; if not, write to the Free Software Foundation, Inc.,
103+# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
104+#
105+
106+SUBDIRS =
107+
108
109=== renamed directory 'libutouch-geis-xcb/geis' => 'libutouch-geis/geis'
110=== modified file 'testsuite/geis1/Makefile.am'
111--- testsuite/geis1/Makefile.am 2010-11-23 18:06:40 +0000
112+++ testsuite/geis1/Makefile.am 2010-12-31 20:37:54 +0000
113@@ -9,8 +9,6 @@
114 test_targets =
115 endif
116
117-geis_impl = xcb
118-
119 TESTS = $(test_targets)
120
121 check_PROGRAMS = $(test_targets)
122@@ -22,7 +20,7 @@
123 check_geis_internals_CFLAGS = \
124 -I$(top_srcdir) \
125 -I$(top_srcdir)/include \
126- -I$(top_srcdir)/libutouch-geis-$(geis_impl) \
127+ -I$(top_srcdir)/libutouch-geis \
128 $(CHECK_CFLAGS)
129
130 check_geis_internals_LDADD = \
131
132=== modified file 'testsuite/geis2/Makefile.am'
133--- testsuite/geis2/Makefile.am 2010-12-21 01:47:05 +0000
134+++ testsuite/geis2/Makefile.am 2010-12-31 20:37:54 +0000
135@@ -29,14 +29,11 @@
136 check_geis2_api_CFLAGS = \
137 -I$(top_srcdir) \
138 -I$(top_srcdir)/include \
139- -I$(top_srcdir)/libutouch-geis-xcb \
140+ -I$(top_srcdir)/libutouch-geis \
141 $(CHECK_CFLAGS)
142
143 check_geis2_api_LDADD = \
144 $(top_builddir)/libutouch-geis/libutouch-geis.la \
145- $(X11XCB_LIBS) \
146- $(XCB_LIBS) \
147- $(XI2_LIBS) \
148 $(CHECK_LIBS)
149
150 MOSTLYCLEANFILES = geis2_api.log
151
152=== modified file 'testsuite/geistest/Makefile.am'
153--- testsuite/geistest/Makefile.am 2010-12-20 18:06:36 +0000
154+++ testsuite/geistest/Makefile.am 2010-12-31 20:37:54 +0000
155@@ -7,7 +7,7 @@
156 geistest_CPPFLAGS = \
157 -I$(top_srcdir) \
158 -I$(top_srcdir)/include \
159- -I$(top_srcdir)/libutouch-geis-xcb \
160+ -I$(top_srcdir)/libutouch-geis \
161 $(XCB_CFLAGS)
162
163 geistest_LDADD = \
164
165=== modified file 'testsuite/libutouch-geis/Makefile.am'
166--- testsuite/libutouch-geis/Makefile.am 2010-12-21 13:59:31 +0000
167+++ testsuite/libutouch-geis/Makefile.am 2010-12-31 20:37:54 +0000
168@@ -44,7 +44,7 @@
169 check_geis2_internals_CFLAGS = \
170 -I$(top_srcdir) \
171 -I$(top_srcdir)/include \
172- -I$(top_srcdir)/libutouch-geis-xcb \
173+ -I$(top_srcdir)/libutouch-geis \
174 $(CHECK_CFLAGS)
175
176 #

Subscribers

People subscribed via source and target branches

to all changes: